Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: chrome/browser/signin/signin_manager_unittest.cc

Issue 964553002: Remove support for special "sign in process" state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ocl3
Patch Set: rebased Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/signin/chrome_signin_client.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_manager_unittest.cc
diff --git a/chrome/browser/signin/signin_manager_unittest.cc b/chrome/browser/signin/signin_manager_unittest.cc
index 22fb797a2320c17d6c7c622c2e2a02db806a0083..6e99f4f3416c42cf6d65a51c38c3cf478f0d74d6 100644
--- a/chrome/browser/signin/signin_manager_unittest.cc
+++ b/chrome/browser/signin/signin_manager_unittest.cc
@@ -306,23 +306,6 @@ TEST_F(SigninManagerTest, SignOutWhileProhibited) {
EXPECT_FALSE(manager_->IsAuthenticated());
}
-TEST_F(SigninManagerTest, TestIsWebBasedSigninFlowURL) {
- EXPECT_FALSE(SigninManager::IsWebBasedSigninFlowURL(
- GURL("http://www.google.com")));
- EXPECT_TRUE(SigninManager::IsWebBasedSigninFlowURL(
- GURL("https://accounts.google.com/ServiceLogin?service=chromiumsync")));
- EXPECT_FALSE(SigninManager::IsWebBasedSigninFlowURL(
- GURL("http://accounts.google.com/ServiceLogin?service=chromiumsync")));
- // http, not https, should not be treated as web based signin.
- EXPECT_FALSE(SigninManager::IsWebBasedSigninFlowURL(
- GURL("http://accounts.google.com/ServiceLogin?service=googlemail")));
- // chromiumsync is double-embedded in a continue query param.
- EXPECT_TRUE(SigninManager::IsWebBasedSigninFlowURL(
- GURL("https://accounts.google.com/CheckCookie?"
- "continue=https%3A%2F%2Fwww.google.com%2Fintl%2Fen-US%2Fchrome"
- "%2Fblank.html%3Fsource%3D3%26nonadv%3D1&service=chromiumsync")));
-}
-
TEST_F(SigninManagerTest, Prohibited) {
g_browser_process->local_state()->SetString(
prefs::kGoogleServicesUsernamePattern, ".*@google.com");
« no previous file with comments | « chrome/browser/signin/chrome_signin_client.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698