Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: chrome/browser/policy/url_blacklist_manager_unittest.cc

Issue 964553002: Remove support for special "sign in process" state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ocl3
Patch Set: rebased Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/policy/policy_helpers.cc ('k') | chrome/browser/signin/chrome_signin_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/policy/url_blacklist_manager_unittest.cc
diff --git a/chrome/browser/policy/url_blacklist_manager_unittest.cc b/chrome/browser/policy/url_blacklist_manager_unittest.cc
index 688d35b0822f359be24f34a110b966a4c4cdb5d8..ef98fbc50f4de329e88a42f0bc04489d6d96377b 100644
--- a/chrome/browser/policy/url_blacklist_manager_unittest.cc
+++ b/chrome/browser/policy/url_blacklist_manager_unittest.cc
@@ -654,22 +654,6 @@ TEST_F(URLBlacklistManagerTest, DontBlockResources) {
request->SetLoadFlags(net::LOAD_MAIN_FRAME);
EXPECT_TRUE(blacklist_manager_->IsRequestBlocked(*request.get(), &reason));
EXPECT_EQ(net::ERR_BLOCKED_BY_ADMINISTRATOR, reason);
-
- // On most platforms, sync gets a free pass due to signin flows.
- bool block_signin_urls = false;
-#if defined(OS_CHROMEOS)
- // There are no sync specific signin flows on Chrome OS, so no special
- // treatment.
- block_signin_urls = true;
-#endif
-
- GURL sync_url(GaiaUrls::GetInstance()->service_login_url().Resolve(
- "?service=chromiumsync"));
- scoped_ptr<net::URLRequest> sync_request(context.CreateRequest(
- sync_url, net::DEFAULT_PRIORITY, NULL, NULL));
- sync_request->SetLoadFlags(net::LOAD_MAIN_FRAME);
- EXPECT_EQ(block_signin_urls,
- blacklist_manager_->IsRequestBlocked(*sync_request.get(), &reason));
}
TEST_F(URLBlacklistManagerTest, DefaultBlacklistExceptions) {
« no previous file with comments | « chrome/browser/policy/policy_helpers.cc ('k') | chrome/browser/signin/chrome_signin_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698