Issue 89723002: Convert the rest of the functions in core.cc to use CreateFunctionTemplate.

Issue 89723002: Convert the rest of the functions in core.cc to use CreateFunctionTemplate. (Closed)

Created:
7 years ago by Aaron Boodman

Modified:
7 years ago

Reviewers:
abarth-chromium

CC:
chromium-reviews, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Convert the rest of the functions in core.cc to use CreateFunctionTemplate. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237492

Patch Set 2 : realized didn't need changes to ArrayBuffer::Private #

Total comments: 3

Patch Set 3 : rebase+comments #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+246 lines, -155 lines)			Patch
M	gin/arguments.h	View		3 chunks	+15 lines, -13 lines	0 comments	Download
M	gin/arguments.cc	View		3 chunks	+16 lines, -3 lines	0 comments	Download
M	gin/array_buffer.h	View	1 2	3 chunks	+8 lines, -8 lines	0 comments	Download
M	gin/array_buffer.cc	View	1	3 chunks	+12 lines, -14 lines	0 comments	Download
M	gin/converter.h	View		15 chunks	+32 lines, -18 lines	0 comments	Download
M	gin/converter.cc	View		13 chunks	+24 lines, -17 lines	0 comments	Download
M	gin/converter_unittest.cc	View		3 chunks	+8 lines, -4 lines	0 comments	Download
M	gin/dictionary.h	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	gin/dictionary.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	gin/function_template.h	View		11 chunks	+71 lines, -8 lines	0 comments	Download
M	gin/function_template.h.pump	View		3 chunks	+6 lines, -2 lines	0 comments	Download
M	gin/modules/module_registry.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	gin/runner_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gin/wrappable.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	gin/wrappable.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	gin/wrappable_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/public/bindings/js/core.cc	View		3 chunks	+30 lines, -49 lines	0 comments	Download
M	mojo/public/bindings/js/handle.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/public/bindings/js/handle.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	mojo/public/bindings/js/waiting_callback.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

The copy was actually in the function definition in core.cc -- I had neglected to ...

7 years ago (2013-11-27 00:03:47 UTC) #2

abarth-chromium

LGTM! https://codereview.chromium.org/89723002/diff/20001/gin/array_buffer.h File gin/array_buffer.h (right): https://codereview.chromium.org/89723002/diff/20001/gin/array_buffer.h#newcode36 gin/array_buffer.h:36: class Private; If you're not going to move ...

7 years ago (2013-11-27 00:20:09 UTC) #3

Aaron Boodman

https://codereview.chromium.org/89723002/diff/20001/gin/array_buffer.h File gin/array_buffer.h (right): https://codereview.chromium.org/89723002/diff/20001/gin/array_buffer.h#newcode36 gin/array_buffer.h:36: class Private; On 2013/11/27 00:20:10, abarth wrote: > If ...

7 years ago (2013-11-27 00:34:42 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/89723002/40001

7 years ago (2013-11-27 00:36:16 UTC) #5

Message was sent while issue was closed.

Change committed as 237492

Expand Messages | Collapse Messages