Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: gin/runner_unittest.cc

Issue 89723002: Convert the rest of the functions in core.cc to use CreateFunctionTemplate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase+comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/modules/module_registry.cc ('k') | gin/wrappable.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/runner_unittest.cc
diff --git a/gin/runner_unittest.cc b/gin/runner_unittest.cc
index 9493cf1e181e13bf03cf03938599f1a3326e50a0..3723956df6a4ecdcf2a0aa611eb62f7b85828410 100644
--- a/gin/runner_unittest.cc
+++ b/gin/runner_unittest.cc
@@ -28,7 +28,7 @@ TEST(RunnerTest, Run) {
runner.Run(source, "test_data.js");
std::string result;
- EXPECT_TRUE(Converter<std::string>::FromV8(
+ EXPECT_TRUE(Converter<std::string>::FromV8(isolate,
runner.global()->Get(StringToV8(isolate, "result")),
&result));
EXPECT_EQ("PASS", result);
« no previous file with comments | « gin/modules/module_registry.cc ('k') | gin/wrappable.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698