Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Unified Diff: gin/function_template.h.pump

Issue 89723002: Convert the rest of the functions in core.cc to use CreateFunctionTemplate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase+comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/function_template.h ('k') | gin/modules/module_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/function_template.h.pump
diff --git a/gin/function_template.h.pump b/gin/function_template.h.pump
index 7e90324febdd22b92838eaa6af11506b2fc8bb6f..5812c80d9c9ce3ecb3185f7bcbeb1411d415ce78 100644
--- a/gin/function_template.h.pump
+++ b/gin/function_template.h.pump
@@ -5,7 +5,7 @@ $$
$$ http://code.google.com/p/googletest/wiki/PumpManual
$$
-$var MAX_ARITY = 3
+$var MAX_ARITY = 4
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
@@ -48,7 +48,6 @@ struct RemoveConstRef<const T&> {
// JavaScript references in V8.
class CallbackHolderBase : public Wrappable {
public:
- static void EnsureRegistered(PerIsolateData* isolate_data);
virtual WrapperInfo* GetWrapperInfo() OVERRIDE;
static WrapperInfo kWrapperInfo;
protected:
@@ -147,6 +146,11 @@ $for ARG ||
} // namespace internal
+// This should be called once per-isolate to initialize the function template
+// system.
+void InitFunctionTemplates(PerIsolateData* isolate_data);
+
+
// This has to be outside the internal namespace because template
// specializations must be declared in the same namespace as the original
// template.
« no previous file with comments | « gin/function_template.h ('k') | gin/modules/module_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698