Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3676)

Unified Diff: gin/dictionary.cc

Issue 89723002: Convert the rest of the functions in core.cc to use CreateFunctionTemplate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase+comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/dictionary.h ('k') | gin/function_template.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/dictionary.cc
diff --git a/gin/dictionary.cc b/gin/dictionary.cc
index ca6227efc236c030ff4210f5f5cd4dab901ba9cb..e8b2ac3a4274d6ebc039cfd12dd5fa00ea05e490 100644
--- a/gin/dictionary.cc
+++ b/gin/dictionary.cc
@@ -30,11 +30,12 @@ v8::Handle<v8::Value> Converter<Dictionary>::ToV8(v8::Isolate* isolate,
return val.object_;
}
-bool Converter<Dictionary>::FromV8(v8::Handle<v8::Value> val,
+bool Converter<Dictionary>::FromV8(v8::Isolate* isolate,
+ v8::Handle<v8::Value> val,
Dictionary* out) {
if (!val->IsObject())
return false;
- *out = Dictionary(out->isolate(), v8::Handle<v8::Object>::Cast(val));
+ *out = Dictionary(isolate, v8::Handle<v8::Object>::Cast(val));
return true;
}
« no previous file with comments | « gin/dictionary.h ('k') | gin/function_template.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698