Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: gin/wrappable.cc

Issue 89723002: Convert the rest of the functions in core.cc to use CreateFunctionTemplate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase+comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/wrappable.h ('k') | gin/wrappable_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/wrappable.cc
diff --git a/gin/wrappable.cc b/gin/wrappable.cc
index 943927ba0da2f11f4d30b0a560015aa1e62ab0a8..5c7c629b7e4e50fd264255db70269af4ab82c582 100644
--- a/gin/wrappable.cc
+++ b/gin/wrappable.cc
@@ -51,8 +51,8 @@ v8::Handle<v8::Value> Converter<Wrappable*>::ToV8(v8::Isolate* isolate,
return v8::Local<v8::Object>::New(isolate, val->wrapper_);
}
-bool Converter<Wrappable*>::FromV8(v8::Handle<v8::Value> val,
- Wrappable** out) {
+bool Converter<Wrappable*>::FromV8(v8::Isolate* isolate,
+ v8::Handle<v8::Value> val, Wrappable** out) {
if (!val->IsObject())
return false;
v8::Handle<v8::Object> obj = v8::Handle<v8::Object>::Cast(val);
« no previous file with comments | « gin/wrappable.h ('k') | gin/wrappable_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698