Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: mojo/public/bindings/js/waiting_callback.cc

Issue 89723002: Convert the rest of the functions in core.cc to use CreateFunctionTemplate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase+comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/bindings/js/handle.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/bindings/js/waiting_callback.cc
diff --git a/mojo/public/bindings/js/waiting_callback.cc b/mojo/public/bindings/js/waiting_callback.cc
index d2613fa6f3d6fe8de439bf989a764f108d24e260..5da2f3ce4b6fd9c90ea5d6df9523776aa4000ed8 100644
--- a/mojo/public/bindings/js/waiting_callback.cc
+++ b/mojo/public/bindings/js/waiting_callback.cc
@@ -62,7 +62,7 @@ void WaitingCallback::OnHandleReady(MojoResult result) {
v8::Handle<v8::Value> hidden_value =
GetWrapper(isolate)->GetHiddenValue(GetHiddenPropertyName(isolate));
v8::Handle<v8::Function> callback;
- CHECK(gin::ConvertFromV8(hidden_value, &callback));
+ CHECK(gin::ConvertFromV8(isolate, hidden_value, &callback));
v8::Handle<v8::Value> args[] = { gin::ConvertToV8(isolate, result) };
runner_->Call(callback, runner_->global(), 1, args);
« no previous file with comments | « mojo/public/bindings/js/handle.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698