Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3677)

Unified Diff: gin/dictionary.h

Issue 89723002: Convert the rest of the functions in core.cc to use CreateFunctionTemplate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase+comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/converter_unittest.cc ('k') | gin/dictionary.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/dictionary.h
diff --git a/gin/dictionary.h b/gin/dictionary.h
index f011779fa15c33eadc3d15a338105e33d252835a..46232e1075431eea120dab5cdab5f29e77801836 100644
--- a/gin/dictionary.h
+++ b/gin/dictionary.h
@@ -20,7 +20,7 @@ class Dictionary {
template<typename T>
bool Get(const std::string& key, T* out) {
v8::Handle<v8::Value> val = object_->Get(StringToV8(isolate_, key));
- return ConvertFromV8(val, out);
+ return ConvertFromV8(isolate_, val, out);
}
template<typename T>
@@ -33,6 +33,7 @@ class Dictionary {
private:
friend struct Converter<Dictionary>;
+ // TODO(aa): Remove this. Instead, get via FromV8(), Set(), and Get().
v8::Isolate* isolate_;
v8::Handle<v8::Object> object_;
};
@@ -41,7 +42,8 @@ template<>
struct Converter<Dictionary> {
static v8::Handle<v8::Value> ToV8(v8::Isolate* isolate,
Dictionary val);
- static bool FromV8(v8::Handle<v8::Value> val,
+ static bool FromV8(v8::Isolate* isolate,
+ v8::Handle<v8::Value> val,
Dictionary* out);
};
« no previous file with comments | « gin/converter_unittest.cc ('k') | gin/dictionary.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698