| Index: gin/dictionary.h
|
| diff --git a/gin/dictionary.h b/gin/dictionary.h
|
| index f011779fa15c33eadc3d15a338105e33d252835a..46232e1075431eea120dab5cdab5f29e77801836 100644
|
| --- a/gin/dictionary.h
|
| +++ b/gin/dictionary.h
|
| @@ -20,7 +20,7 @@ class Dictionary {
|
| template<typename T>
|
| bool Get(const std::string& key, T* out) {
|
| v8::Handle<v8::Value> val = object_->Get(StringToV8(isolate_, key));
|
| - return ConvertFromV8(val, out);
|
| + return ConvertFromV8(isolate_, val, out);
|
| }
|
|
|
| template<typename T>
|
| @@ -33,6 +33,7 @@ class Dictionary {
|
| private:
|
| friend struct Converter<Dictionary>;
|
|
|
| + // TODO(aa): Remove this. Instead, get via FromV8(), Set(), and Get().
|
| v8::Isolate* isolate_;
|
| v8::Handle<v8::Object> object_;
|
| };
|
| @@ -41,7 +42,8 @@ template<>
|
| struct Converter<Dictionary> {
|
| static v8::Handle<v8::Value> ToV8(v8::Isolate* isolate,
|
| Dictionary val);
|
| - static bool FromV8(v8::Handle<v8::Value> val,
|
| + static bool FromV8(v8::Isolate* isolate,
|
| + v8::Handle<v8::Value> val,
|
| Dictionary* out);
|
| };
|
|
|
|
|