Convert the rest of the functions in core.cc to use CreateFunctionTemplate.

gin/array_buffer.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GIN_ARRAY_BUFFER_H_
 #define GIN_ARRAY_BUFFER_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
 #include "gin/converter.h"
 #include "v8/include/v8.h"
 
 namespace gin {
 
 class ArrayBufferAllocator : public v8::ArrayBuffer::Allocator {
  public:
   virtual void* Allocate(size_t length) OVERRIDE;
   virtual void* AllocateUninitialized(size_t length) OVERRIDE;
   virtual void Free(void* data, size_t length) OVERRIDE;
 
   static ArrayBufferAllocator* SharedInstance();
 };
 
 class ArrayBuffer {
  public:
+  ArrayBuffer();
   explicit ArrayBuffer(v8::Isolate* isolate);
   ArrayBuffer(v8::Isolate* isolate, v8::Handle<v8::ArrayBuffer> buffer);
   ~ArrayBuffer();
 
   void* bytes() const { return bytes_; }
   size_t num_bytes() const { return num_bytes_; }
 
-  v8::Isolate* isolate() const { return isolate_; }
-
  private:
   class Private;

[abarth-chromium, 2013/11/27 00:20:10]

If you're not going to move this into the header, maybe we should mark
ArrayBuffer as DISALLOW_COPY_AND_ASSIGN so that folks don't get an obscure
compile error?

[Aaron Boodman, 2013/11/27 00:34:43]

Good idea, but we need assign because Arguments::GetNext() uses it. I added
DISALLOW_COPY though.

 
-  v8::Isolate* isolate_;
   scoped_refptr<Private> private_;
   void* bytes_;
   size_t num_bytes_;
 };
 
 template<>
 struct Converter<ArrayBuffer> {
-  static bool FromV8(v8::Handle<v8::Value> val,
+  static bool FromV8(v8::Isolate* isolate, v8::Handle<v8::Value> val,
                      ArrayBuffer* out);
 };
 
 class ArrayBufferView {
  public:
-  explicit ArrayBufferView(v8::Isolate* isolate);
+  ArrayBufferView();
   ArrayBufferView(v8::Isolate* isolate, v8::Handle<v8::ArrayBufferView> view);
   ~ArrayBufferView();
 
   void* bytes() const {
     return static_cast<uint8_t*>(array_buffer_.bytes()) + offset_;
   }
   size_t num_bytes() const { return num_bytes_; }
 
-  v8::Isolate* isolate() const { return array_buffer_.isolate(); }
-
  private:
   ArrayBuffer array_buffer_;
   size_t offset_;
   size_t num_bytes_;
 };
 
 template<>
 struct Converter<ArrayBufferView> {
-  static bool FromV8(v8::Handle<v8::Value> val,
+  static bool FromV8(v8::Isolate* isolate, v8::Handle<v8::Value> val,
                      ArrayBufferView* out);
 };
 
 }  // namespace gin
 
 #endif  // GIN_ARRAY_BUFFER_H_