Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: gin/converter_unittest.cc

Issue 89723002: Convert the rest of the functions in core.cc to use CreateFunctionTemplate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase+comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/converter.cc ('k') | gin/dictionary.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/converter_unittest.cc
diff --git a/gin/converter_unittest.cc b/gin/converter_unittest.cc
index 0a6bbbabdd2873c15929986250d6b37757bdbbc6..58ae62589defaa83e1795dced51e99a9c342d188 100644
--- a/gin/converter_unittest.cc
+++ b/gin/converter_unittest.cc
@@ -57,11 +57,13 @@ TEST_F(ConverterTest, Bool) {
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_data); ++i) {
bool result = false;
- EXPECT_TRUE(Converter<bool>::FromV8(test_data[i].input, &result));
+ EXPECT_TRUE(Converter<bool>::FromV8(instance_->isolate(),
+ test_data[i].input, &result));
EXPECT_EQ(test_data[i].expected, result);
result = true;
- EXPECT_TRUE(Converter<bool>::FromV8(test_data[i].input, &result));
+ EXPECT_TRUE(Converter<bool>::FromV8(instance_->isolate(),
+ test_data[i].input, &result));
EXPECT_EQ(test_data[i].expected, result);
}
}
@@ -97,7 +99,8 @@ TEST_F(ConverterTest, Int32) {
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_data_from); ++i) {
int32_t result = std::numeric_limits<int32_t>::min();
- bool success = Converter<int32_t>::FromV8(test_data_from[i].input, &result);
+ bool success = Converter<int32_t>::FromV8(instance_->isolate(),
+ test_data_from[i].input, &result);
EXPECT_EQ(test_data_from[i].expect_sucess, success) << i;
if (success)
EXPECT_EQ(test_data_from[i].expected_result, result) << i;
@@ -122,7 +125,8 @@ TEST_F(ConverterTest, Vector) {
}
std::vector<int> actual;
- EXPECT_TRUE(Converter<std::vector<int> >::FromV8(js_array, &actual));
+ EXPECT_TRUE(Converter<std::vector<int> >::FromV8(instance_->isolate(),
+ js_array, &actual));
EXPECT_EQ(expected, actual);
}
« no previous file with comments | « gin/converter.cc ('k') | gin/dictionary.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698