Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: gin/array_buffer.h

Issue 89723002: Convert the rest of the functions in core.cc to use CreateFunctionTemplate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase+comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/arguments.cc ('k') | gin/array_buffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/array_buffer.h
diff --git a/gin/array_buffer.h b/gin/array_buffer.h
index 30d45f91d3c0e78987ffbee9b629d59ad596c502..3169fd021b3b4c2f51b39772f076f5f9b41ac96c 100644
--- a/gin/array_buffer.h
+++ b/gin/array_buffer.h
@@ -24,6 +24,7 @@ class ArrayBufferAllocator : public v8::ArrayBuffer::Allocator {
class ArrayBuffer {
public:
+ ArrayBuffer();
explicit ArrayBuffer(v8::Isolate* isolate);
ArrayBuffer(v8::Isolate* isolate, v8::Handle<v8::ArrayBuffer> buffer);
~ArrayBuffer();
@@ -31,26 +32,25 @@ class ArrayBuffer {
void* bytes() const { return bytes_; }
size_t num_bytes() const { return num_bytes_; }
- v8::Isolate* isolate() const { return isolate_; }
-
private:
class Private;
- v8::Isolate* isolate_;
scoped_refptr<Private> private_;
void* bytes_;
size_t num_bytes_;
+
+ DISALLOW_COPY(ArrayBuffer);
};
template<>
struct Converter<ArrayBuffer> {
- static bool FromV8(v8::Handle<v8::Value> val,
+ static bool FromV8(v8::Isolate* isolate, v8::Handle<v8::Value> val,
ArrayBuffer* out);
};
class ArrayBufferView {
public:
- explicit ArrayBufferView(v8::Isolate* isolate);
+ ArrayBufferView();
ArrayBufferView(v8::Isolate* isolate, v8::Handle<v8::ArrayBufferView> view);
~ArrayBufferView();
@@ -59,17 +59,17 @@ class ArrayBufferView {
}
size_t num_bytes() const { return num_bytes_; }
- v8::Isolate* isolate() const { return array_buffer_.isolate(); }
-
private:
ArrayBuffer array_buffer_;
size_t offset_;
size_t num_bytes_;
+
+ DISALLOW_COPY(ArrayBufferView);
};
template<>
struct Converter<ArrayBufferView> {
- static bool FromV8(v8::Handle<v8::Value> val,
+ static bool FromV8(v8::Isolate* isolate, v8::Handle<v8::Value> val,
ArrayBufferView* out);
};
« no previous file with comments | « gin/arguments.cc ('k') | gin/array_buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698