Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 878303002: Remove more scrolling code from Sky (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove more scrolling code from Sky None of this code does anything anymore. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b2a622df4e489fc0d1664ca3ef314c62f0fc79e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1185 lines) Patch
M sky/engine/bindings/core/v8/custom/V8ElementCustom.cpp View 1 chunk +0 lines, -32 lines 0 comments Download
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 4 chunks +2 lines, -7 lines 0 comments Download
M sky/engine/core/css/CSSPrimitiveValueMappings.h View 7 chunks +1 line, -44 lines 0 comments Download
M sky/engine/core/css/CSSProperties.in View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSValueKeywords.in View 2 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/core/css/MediaValues.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser-in.cpp View 3 chunks +4 lines, -8 lines 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/css/resolver/CSSToStyleMap.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/resolver/StyleBuilderCustom.cpp View 4 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/core/dom/Document.h View 3 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 4 chunks +1 line, -31 lines 0 comments Download
M sky/engine/core/dom/Element.h View 2 chunks +0 lines, -11 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 6 chunks +1 line, -62 lines 0 comments Download
M sky/engine/core/dom/Element.idl View 1 chunk +0 lines, -9 lines 0 comments Download
M sky/engine/core/dom/ElementRareData.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/dom/ElementRareData.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Range.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/editing/Editor.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/editing/EditorCommand.cpp View 2 chunks +1 line, -8 lines 0 comments Download
M sky/engine/core/editing/FrameSelection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/editing/VisibleUnits.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/frame/FrameView.h View 4 chunks +4 lines, -5 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/frame/LocalFrame.h View 2 chunks +1 line, -4 lines 0 comments Download
M sky/engine/core/frame/LocalFrame.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M sky/engine/core/html/canvas/CanvasRenderingContext2D.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +0 lines, -36 lines 0 comments Download
M sky/engine/core/html/canvas/CanvasRenderingContext2D.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/inspector/InspectorTraceEvents.h View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/inspector/InspectorTraceEvents.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/core/loader/FrameLoaderClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/engine/core/page/AutoscrollController.h View 1 chunk +0 lines, -76 lines 0 comments Download
D sky/engine/core/page/AutoscrollController.cpp View 1 chunk +0 lines, -182 lines 0 comments Download
M sky/engine/core/page/EventHandler.h View 5 chunks +0 lines, -23 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 4 chunks +0 lines, -60 lines 0 comments Download
M sky/engine/core/page/FocusController.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/page/Page.h View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/page/Page.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 5 chunks +3 lines, -19 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 5 chunks +0 lines, -44 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 7 chunks +0 lines, -175 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.cpp View 2 chunks +2 lines, -13 lines 0 comments Download
M sky/engine/core/rendering/RenderInline.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 4 chunks +0 lines, -15 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 2 chunks +0 lines, -16 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 2 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 7 chunks +4 lines, -48 lines 0 comments Download
M sky/engine/core/rendering/RenderTheme.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderView.h View 1 chunk +3 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 3 chunks +8 lines, -12 lines 0 comments Download
M sky/engine/core/rendering/style/FillLayer.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 4 chunks +0 lines, -10 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyleConstants.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareNonInheritedData.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareNonInheritedData.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/style/StyleWillChangeData.h View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/core/rendering/style/StyleWillChangeData.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/platform/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/RuntimeEnabledFeatures.in View 3 chunks +0 lines, -6 lines 0 comments Download
D sky/engine/platform/scroll/ScrollTypes.h View 1 chunk +0 lines, -83 lines 0 comments Download
M sky/engine/public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/public/web/WebView.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/AssertMatchingEnums.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/FrameLoaderClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/FrameLoaderClientImpl.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/web/WebLocalFrameImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 4 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 4 chunks +0 lines, -8 lines 0 comments Download
M sky/examples/flights-app/app-scrollable.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/flights/index.sky View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 11 months ago (2015-01-27 21:50:03 UTC) #1
eseidel
lgtm
5 years, 11 months ago (2015-01-27 23:07:50 UTC) #2
abarth-chromium
5 years, 11 months ago (2015-01-27 23:20:19 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b2a622df4e489fc0d1664ca3ef314c62f0fc79e9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698