Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: sky/engine/core/dom/Element.cpp

Issue 878303002: Remove more scrolling code from Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/Element.h ('k') | sky/engine/core/dom/Element.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/Element.cpp
diff --git a/sky/engine/core/dom/Element.cpp b/sky/engine/core/dom/Element.cpp
index 4ea63936b1c13abd3a9b814d87c7b7a1f5c85eb1..501cc2b803f8deb5cf05687ab9c2fc9b60eae70a 100644
--- a/sky/engine/core/dom/Element.cpp
+++ b/sky/engine/core/dom/Element.cpp
@@ -398,50 +398,6 @@ int Element::clientHeight()
return 0;
}
-int Element::scrollLeft()
-{
- // FIXME(sky): Remove(scrolling)
- return 0;
-}
-
-int Element::scrollTop()
-{
- // FIXME(sky): Remove(scrolling)
- return 0;
-}
-
-void Element::setScrollLeft(int newLeft)
-{
- // FIXME(sky): Remove(scrolling)
-}
-
-void Element::setScrollLeft(const Dictionary& scrollOptionsHorizontal, ExceptionState& exceptionState)
-{
- // FIXME(sky): Remove(scrolling)
-}
-
-void Element::setScrollTop(int newTop)
-{
- // FIXME(sky): Remove(scrolling)
-}
-
-void Element::setScrollTop(const Dictionary& scrollOptionsVertical, ExceptionState& exceptionState)
-{
- // FIXME(sky): Remove(scrolling)
-}
-
-int Element::scrollWidth()
-{
- // FIXME(sky): Remove(scrolling)
- return 0;
-}
-
-int Element::scrollHeight()
-{
- // FIXME(sky): Remove(scrolling)
- return 0;
-}
-
PassRefPtr<ClientRectList> Element::getClientRects()
{
document().updateLayout();
@@ -455,7 +411,6 @@ PassRefPtr<ClientRectList> Element::getClientRects()
Vector<FloatQuad> quads;
renderBoxModelObject->absoluteQuads(quads);
- document().adjustFloatQuadsForScroll(quads);
return ClientRectList::create(quads);
}
@@ -475,7 +430,6 @@ PassRefPtr<ClientRect> Element::getBoundingClientRect()
for (size_t i = 1; i < quads.size(); ++i)
result.unite(quads[i].boundingBox());
- document().adjustFloatRectForScroll(result);
return ClientRect::create(result);
}
@@ -717,8 +671,6 @@ void Element::removedFrom(ContainerNode* insertionPoint)
{
bool wasInDocument = insertionPoint->inDocument();
- setSavedLayerScrollOffset(IntSize());
-
if (insertionPoint->isInTreeScope() && treeScope() == document()) {
const AtomicString& idValue = getIdAttribute();
if (!idValue.isNull())
@@ -1115,8 +1067,7 @@ void Element::updateFocusAppearance(bool /*restorePreviousSelection*/)
// and we don't want to change the focus to a new Element.
frame->selection().setSelection(newSelection, FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle | FrameSelection::DoNotSetFocus);
frame->selection().revealSelection();
- } else if (renderer())
- renderer()->scrollRectToVisible(boundingBox());
+ }
}
void Element::blur()
@@ -1408,18 +1359,6 @@ void Element::didMoveToNewDocument(Document& oldDocument)
reResolveURLsInInlineStyle(document(), ensureMutableInlineStyle());
}
-IntSize Element::savedLayerScrollOffset() const
-{
- return hasRareData() ? elementRareData()->savedLayerScrollOffset() : IntSize();
-}
-
-void Element::setSavedLayerScrollOffset(const IntSize& size)
-{
- if (size.isZero() && !hasRareData())
- return;
- ensureElementRareData().setSavedLayerScrollOffset(size);
-}
-
void Element::cloneAttributesFromElement(const Element& other)
{
other.synchronizeAllAttributes();
« no previous file with comments | « sky/engine/core/dom/Element.h ('k') | sky/engine/core/dom/Element.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698