Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Unified Diff: sky/engine/core/css/CSSComputedStyleDeclaration.cpp

Issue 878303002: Remove more scrolling code from Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/core.gni ('k') | sky/engine/core/css/CSSPrimitiveValueMappings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/css/CSSComputedStyleDeclaration.cpp
diff --git a/sky/engine/core/css/CSSComputedStyleDeclaration.cpp b/sky/engine/core/css/CSSComputedStyleDeclaration.cpp
index dea00e523bcacd41be5d8d87b89c8ec0ae9678a1..fea63e0811cfa8d54497deb965eae98bb42291f7 100644
--- a/sky/engine/core/css/CSSComputedStyleDeclaration.cpp
+++ b/sky/engine/core/css/CSSComputedStyleDeclaration.cpp
@@ -159,7 +159,6 @@ static const CSSPropertyID staticComputableProperties[] = {
CSSPropertyPointerEvents,
CSSPropertyPosition,
CSSPropertyRight,
- CSSPropertyScrollBehavior,
CSSPropertySpeak,
CSSPropertyTableLayout,
CSSPropertyTabSize,
@@ -869,13 +868,11 @@ static PassRefPtr<CSSValue> valueForAnimationDirection(Timing::PlaybackDirection
}
}
-static PassRefPtr<CSSValue> valueForWillChange(const Vector<CSSPropertyID>& willChangeProperties, bool willChangeContents, bool willChangeScrollPosition)
+static PassRefPtr<CSSValue> valueForWillChange(const Vector<CSSPropertyID>& willChangeProperties, bool willChangeContents)
{
RefPtr<CSSValueList> list = CSSValueList::createCommaSeparated();
if (willChangeContents)
list->append(cssValuePool().createIdentifierValue(CSSValueContents));
- if (willChangeScrollPosition)
- list->append(cssValuePool().createIdentifierValue(CSSValueScrollPosition));
for (size_t i = 0; i < willChangeProperties.size(); ++i)
list->append(cssValuePool().createIdentifierValue(willChangeProperties[i]));
if (!list->length())
@@ -1687,8 +1684,6 @@ PassRefPtr<CSSValue> CSSComputedStyleDeclaration::getPropertyCSSValue(CSSPropert
return cssValuePool().createValue(style->position());
case CSSPropertyRight:
return valueForPositionOffset(*style, CSSPropertyRight, renderer);
- case CSSPropertyScrollBehavior:
- return cssValuePool().createValue(style->scrollBehavior());
case CSSPropertyTableLayout:
return cssValuePool().createValue(style->tableLayout());
case CSSPropertyTextAlign:
@@ -1815,7 +1810,7 @@ PassRefPtr<CSSValue> CSSComputedStyleDeclaration::getPropertyCSSValue(CSSPropert
}
return pixelValueForLength(style->width(), *style);
case CSSPropertyWillChange:
- return valueForWillChange(style->willChangeProperties(), style->willChangeContents(), style->willChangeScrollPosition());
+ return valueForWillChange(style->willChangeProperties(), style->willChangeContents());
case CSSPropertyWordBreak:
return cssValuePool().createValue(style->wordBreak());
case CSSPropertyWordSpacing:
« no previous file with comments | « sky/engine/core/core.gni ('k') | sky/engine/core/css/CSSPrimitiveValueMappings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698