Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: sky/engine/core/rendering/RenderLayer.cpp

Issue 878303002: Remove more scrolling code from Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderLayer.h ('k') | sky/engine/core/rendering/RenderObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderLayer.cpp
diff --git a/sky/engine/core/rendering/RenderLayer.cpp b/sky/engine/core/rendering/RenderLayer.cpp
index f4550c129288a019b58129e10669a37c2a17b874..ded1c968d26d1a6cac700ca7eccecb342249c844 100644
--- a/sky/engine/core/rendering/RenderLayer.cpp
+++ b/sky/engine/core/rendering/RenderLayer.cpp
@@ -177,11 +177,6 @@ void RenderLayer::dirtyAncestorChainHasSelfPaintingLayerDescendantStatus()
}
}
-bool RenderLayer::scrollsWithRespectTo(const RenderLayer* other) const
-{
- return ancestorScrollingLayer() != other->ancestorScrollingLayer();
-}
-
void RenderLayer::updateTransformationMatrix()
{
if (m_transform) {
@@ -361,21 +356,10 @@ LayoutPoint RenderLayer::location() const
if (renderer()->isOutOfFlowPositioned() && enclosingPositionedAncestor()) {
RenderLayer* positionedParent = enclosingPositionedAncestor();
- // For positioned layers, we subtract out the enclosing positioned layer's scroll offset.
- if (positionedParent->renderer()->hasOverflowClip()) {
- LayoutSize offset = positionedParent->renderBox()->scrolledContentOffset();
- localPoint -= offset;
- }
-
if (positionedParent->renderer()->isRelPositioned() && positionedParent->renderer()->isRenderInline()) {
LayoutSize offset = toRenderInline(positionedParent->renderer())->offsetForInFlowPositionedInline(*toRenderBox(renderer()));
localPoint += offset;
}
- } else if (parent()) {
- if (parent()->renderer()->hasOverflowClip()) {
- IntSize scrollOffset = parent()->renderBox()->scrolledContentOffset();
- localPoint -= scrollOffset;
- }
}
localPoint.move(offsetForInFlowPosition());
« no previous file with comments | « sky/engine/core/rendering/RenderLayer.h ('k') | sky/engine/core/rendering/RenderObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698