Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Unified Diff: sky/engine/core/page/EventHandler.h

Issue 878303002: Remove more scrolling code from Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/page/AutoscrollController.cpp ('k') | sky/engine/core/page/EventHandler.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/page/EventHandler.h
diff --git a/sky/engine/core/page/EventHandler.h b/sky/engine/core/page/EventHandler.h
index 5aa4aeebd164445236d940ac9b51578ce923a208..0df6d392cc3dfd64c6709babd905d2f173dd5a34 100644
--- a/sky/engine/core/page/EventHandler.h
+++ b/sky/engine/core/page/EventHandler.h
@@ -35,7 +35,6 @@
#include "sky/engine/platform/Timer.h"
#include "sky/engine/platform/geometry/LayoutPoint.h"
#include "sky/engine/platform/heap/Handle.h"
-#include "sky/engine/platform/scroll/ScrollTypes.h"
#include "sky/engine/wtf/Forward.h"
#include "sky/engine/wtf/HashMap.h"
#include "sky/engine/wtf/HashTraits.h"
@@ -43,7 +42,6 @@
namespace blink {
-class AutoscrollController;
class Document;
class Element;
class Event;
@@ -74,18 +72,12 @@ public:
void clear();
void nodeWillBeRemoved(Node&);
- void stopAutoscroll();
-
HitTestResult hitTestResultAtPoint(const LayoutPoint&,
HitTestRequest::HitTestRequestType hitType = HitTestRequest::ReadOnly | HitTestRequest::Active,
const LayoutSize& padding = LayoutSize());
void scheduleCursorUpdate();
- // Attempts to scroll the DOM tree. If that fails, scrolls the view.
- // If the view can't be scrolled either, recursively bubble to the parent frame.
- bool bubblingScroll(ScrollDirection, ScrollGranularity, Node* startingNode = 0);
-
void defaultKeyboardEventHandler(KeyboardEvent*);
bool handleTextInputEvent(const String& text, Event* underlyingEvent = 0, TextEventInputType = TextEventInputKeyboard);
@@ -113,19 +105,6 @@ private:
bool isCursorVisible() const;
void updateCursor();
- // Scrolls the elements of the DOM tree. Returns true if a node was scrolled.
- // False if we reached the root and couldn't scroll anything.
- // direction - The direction to scroll in. If this is a logicl direction, it will be
- // converted to the physical direction based on a node's writing mode.
- // granularity - The units that the scroll delta parameter is in.
- // startNode - The node to start bubbling the scroll from. If a node can't scroll,
- // the scroll bubbles up to the containing block.
- // stopNode - On input, if provided and non-null, the node at which we should stop bubbling on input.
- // On output, if provided and a node was scrolled stopNode will point to that node.
- // delta - The delta to scroll by, in the units of the granularity parameter. (e.g. pixels, lines, pages, etc.)
- // absolutePoint - For wheel scrolls - the location, in absolute coordinates, where the event occured.
- bool scroll(ScrollDirection, ScrollGranularity, Node* startNode = 0, Node** stopNode = 0, float delta = 1.0f, IntPoint absolutePoint = IntPoint());
-
TouchAction intersectTouchAction(const TouchAction, const TouchAction);
TouchAction computeEffectiveTouchAction(const Node&);
@@ -140,8 +119,6 @@ private:
bool capturesDragging() const { return m_capturesDragging; }
- AutoscrollController* autoscrollController() const;
-
LocalFrame* const m_frame;
bool m_capturesDragging;
« no previous file with comments | « sky/engine/core/page/AutoscrollController.cpp ('k') | sky/engine/core/page/EventHandler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698