sky/engine/core/editing/Editor.cpp - Issue 878303002: Remove more scrolling code from Sky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/editing/Editor.cpp

Issue 878303002: Remove more scrolling code from Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/editing/Editor.cpp

diff --git a/sky/engine/core/editing/Editor.cpp b/sky/engine/core/editing/Editor.cpp

index c6b6367e43e273849e3a492b475c8b31b7fe030f..12fa4a9f4056678b2133b91a89bb3d0f6964aacf 100644

--- a/sky/engine/core/editing/Editor.cpp

+++ b/sky/engine/core/editing/Editor.cpp

@@ -721,8 +721,7 @@ PassRefPtr<Range> Editor::findStringAndScrollToVisible(const String& target, Ran

if (!nextMatch)

return nullptr;

- nextMatch->firstNode()->renderer()->scrollRectToVisible(nextMatch->boundingBox(),

- ScrollAlignment::alignCenterIfNeeded, ScrollAlignment::alignCenterIfNeeded);

+ // FIXME(sky): Scroll to visible.

return nextMatch.release();

}

« no previous file with comments | « sky/engine/core/dom/Range.cpp ('k') | sky/engine/core/editing/EditorCommand.cpp » ('j') | no next file with comments »