Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: sky/engine/core/rendering/RenderBoxModelObject.cpp

Issue 878303002: Remove more scrolling code from Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderBox.cpp ('k') | sky/engine/core/rendering/RenderInline.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderBoxModelObject.cpp
diff --git a/sky/engine/core/rendering/RenderBoxModelObject.cpp b/sky/engine/core/rendering/RenderBoxModelObject.cpp
index a9ab8dd745fd595f87ca54adda29bc5b820d2a83..628e49dad4937e256bacf42220c11e8510e2cd16 100644
--- a/sky/engine/core/rendering/RenderBoxModelObject.cpp
+++ b/sky/engine/core/rendering/RenderBoxModelObject.cpp
@@ -442,10 +442,8 @@ void RenderBoxModelObject::paintFillLayerExtended(const PaintInfo& paintInfo, co
context->clip(thisBox->overflowClipRect(rect.location()));
// Adjust the paint rect to reflect a scrolled content box with borders at the ends.
- IntSize offset = thisBox->scrolledContentOffset();
- scrolledPaintRect.move(-offset);
- scrolledPaintRect.setWidth(bLeft + thisBox->scrollWidth() + bRight);
- scrolledPaintRect.setHeight(borderTop() + thisBox->scrollHeight() + borderBottom());
+ scrolledPaintRect.setWidth(bLeft + thisBox->clientWidth() + bRight);
+ scrolledPaintRect.setHeight(borderTop() + thisBox->clientHeight() + borderBottom());
}
GraphicsContextStateSaver backgroundClipStateSaver(*context, false);
@@ -732,15 +730,6 @@ void RenderBoxModelObject::calculateBackgroundImageGeometry(const RenderLayerMod
// destRect will be adjusted later if the background is non-repeating.
// FIXME: transforms spec says that fixed backgrounds behave like scroll inside transforms.
bool fixedAttachment = fillLayer.attachment() == FixedBackgroundAttachment;
-
- if (RuntimeEnabledFeatures::fastMobileScrollingEnabled()) {
- // As a side effect of an optimization to blit on scroll, we do not honor the CSS
- // property "background-attachment: fixed" because it may result in rendering
- // artifacts. Note, these artifacts only appear if we are blitting on scroll of
- // a page that has fixed background images.
- fixedAttachment = false;
- }
-
if (!fixedAttachment) {
geometry.setDestRect(snappedPaintRect);
« no previous file with comments | « sky/engine/core/rendering/RenderBox.cpp ('k') | sky/engine/core/rendering/RenderInline.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698