Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 820783005: More changes to bring together path / geo procs (Closed)

Created:
5 years, 11 months ago by joshua.litt
Modified:
5 years, 11 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@lc1
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

More changes to bring together path / geo procs BUG=skia: Committed: https://skia.googlesource.com/skia/+/71c9260e6fa1798ad1e41b2c2ae9b3cce08bb610

Patch Set 1 #

Patch Set 2 : some asserts for safety #

Total comments: 2

Patch Set 3 : feedback incorporated #

Total comments: 1

Patch Set 4 : feedback incorporated #

Patch Set 5 : rebase #

Patch Set 6 : dm fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -221 lines) Patch
M src/gpu/GrAAConvexPathRenderer.cpp View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 1 2 3 4 3 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/GrGeometryProcessor.h View 1 2 3 7 chunks +48 lines, -31 lines 0 comments Download
M src/gpu/GrGeometryProcessor.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 2 3 4 2 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 4 chunks +5 lines, -6 lines 0 comments Download
M src/gpu/GrOptDrawState.h View 3 chunks +1 line, -5 lines 0 comments Download
M src/gpu/GrOptDrawState.cpp View 2 chunks +2 lines, -12 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 2 3 4 9 chunks +24 lines, -24 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.h View 1 2 3 4 6 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.h View 1 2 3 4 2 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 2 3 4 6 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.h View 1 2 3 4 6 chunks +16 lines, -16 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 1 2 3 4 3 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLProgramDesc.h View 3 chunks +2 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 1 chunk +1 line, -8 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 2 5 chunks +13 lines, -13 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 1 2 2 chunks +5 lines, -7 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
joshualitt
This change just has a bit more cleanup. It might be a tad controversial, but ...
5 years, 11 months ago (2015-01-07 19:31:16 UTC) #3
bsalomon
https://codereview.chromium.org/820783005/diff/20001/src/gpu/GrGeometryProcessor.h File src/gpu/GrGeometryProcessor.h (right): https://codereview.chromium.org/820783005/diff/20001/src/gpu/GrGeometryProcessor.h#newcode134 src/gpu/GrGeometryProcessor.h:134: struct GrAttribute { Should just be "Attribute" if it ...
5 years, 11 months ago (2015-01-13 14:31:45 UTC) #4
bsalomon
5 years, 11 months ago (2015-01-13 14:31:46 UTC) #5
joshualitt
On 2015/01/13 14:31:46, bsalomon wrote: feedback incorporated
5 years, 11 months ago (2015-01-13 19:58:19 UTC) #6
bsalomon
https://codereview.chromium.org/820783005/diff/40001/src/gpu/GrGeometryProcessor.h File src/gpu/GrGeometryProcessor.h (right): https://codereview.chromium.org/820783005/diff/40001/src/gpu/GrGeometryProcessor.h#newcode337 src/gpu/GrGeometryProcessor.h:337: fVertexStride += attribute.fOffset; fail if too many are added?
5 years, 11 months ago (2015-01-13 20:19:22 UTC) #7
joshualitt
On 2015/01/13 20:19:22, bsalomon wrote: > https://codereview.chromium.org/820783005/diff/40001/src/gpu/GrGeometryProcessor.h > File src/gpu/GrGeometryProcessor.h (right): > > https://codereview.chromium.org/820783005/diff/40001/src/gpu/GrGeometryProcessor.h#newcode337 > ...
5 years, 11 months ago (2015-01-13 21:06:53 UTC) #8
bsalomon
lgtm
5 years, 11 months ago (2015-01-13 21:17:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820783005/100001
5 years, 11 months ago (2015-01-14 15:59:37 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 16:12:51 UTC) #12
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/71c9260e6fa1798ad1e41b2c2ae9b3cce08bb610

Powered by Google App Engine
This is Rietveld 408576698