Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 815363002: replace COMPILE_ASSERT with static_assert in chrome/browser/ (Closed)

Created:
6 years ago by Mostyn Bramley-Moore
Modified:
6 years ago
Reviewers:
Nico
CC:
chromium-reviews, asanka, nkostylev+watch_chromium.org, zea+watch_chromium.org, tburkard+watch_chromium.org, browser-components-watch_chromium.org, dcheng, markusheintz_, stevenjb+watch_chromium.org, miu+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, pvalenzuela+watch_chromium.org, benjhayden+dwatch_chromium.org, grt+watch_chromium.org, dzhioev+watch_chromium.org, shishir+watch_chromium.org, jkarlin+watch_chromium.org, chromium-apps-reviews_chromium.org, gavinp+prer_chromium.org, oshima+watch_chromium.org, maniscalco+watch_chromium.org, davidben+watch_chromium.org, hashimoto+watch_chromium.org, tfarina, maxbogue+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in chrome/browser/ BUG=442514 Committed: https://crrev.com/3a46e0bf9308a42642689c4b73b6b8622aeecbe5 Cr-Commit-Position: refs/heads/master@{#309547}

Patch Set 1 #

Patch Set 2 : fixup #

Patch Set 3 : fixup 2 #

Total comments: 10

Patch Set 4 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -146 lines) Patch
M chrome/browser/browsing_data/browsing_data_remover.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_mac.mm View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/consumer_management_service.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/widevine_cdm_component_installer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/diagnostics/diagnostics_metrics.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_item_model_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/alarms/alarms_api.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_helpers.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_api_constants.cc View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_api_helpers.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/external_extension_browsertest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/visit_tracker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/internal_auth.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/mac/relauncher.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/proxy_prefs.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_events.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_field_trial.cc View 1 2 3 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/prerender/prerender_final_status.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_link_manager.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/prerender/prerender_local_predictor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_origin.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profile_resetter/profile_resetter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profile_resetter/profile_resetter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profile_resetter/resettable_settings_snapshot.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.cc View 1 chunk +20 lines, -20 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/signin_error_notifier_ash_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/signin_global_error_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/performance/typed_urls_sync_perf_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/themes/browser_theme_pack.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/exclusive_access/fullscreen_controller_state_test.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/tabs/tab_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings_ui.cc View 1 2 3 4 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Mostyn Bramley-Moore
@Nico: PTAL.
6 years ago (2014-12-21 23:30:53 UTC) #2
Nico
lgtm; optional rambling below https://codereview.chromium.org/815363002/diff/40001/chrome/browser/chromeos/policy/consumer_management_service.cc File chrome/browser/chromeos/policy/consumer_management_service.cc (right): https://codereview.chromium.org/815363002/diff/40001/chrome/browser/chromeos/policy/consumer_management_service.cc#newcode37 chrome/browser/chromeos/policy/consumer_management_service.cc:37: "invalid kStatusString array size."); remove ...
6 years ago (2014-12-23 01:32:13 UTC) #3
Mostyn Bramley-Moore
https://codereview.chromium.org/815363002/diff/40001/chrome/browser/chromeos/policy/consumer_management_service.cc File chrome/browser/chromeos/policy/consumer_management_service.cc (right): https://codereview.chromium.org/815363002/diff/40001/chrome/browser/chromeos/policy/consumer_management_service.cc#newcode37 chrome/browser/chromeos/policy/consumer_management_service.cc:37: "invalid kStatusString array size."); On 2014/12/23 01:32:12, Nico wrote: ...
6 years ago (2014-12-23 08:16:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/815363002/60001
6 years ago (2014-12-23 08:17:25 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-23 09:03:14 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-23 09:04:07 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/3a46e0bf9308a42642689c4b73b6b8622aeecbe5
Cr-Commit-Position: refs/heads/master@{#309547}

Powered by Google App Engine
This is Rietveld 408576698