chrome/browser/diagnostics/diagnostics_metrics.cc - Issue 815363002: replace COMPILE_ASSERT with static_assert in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/diagnostics/diagnostics_metrics.cc

Issue 815363002: replace COMPILE_ASSERT with static_assert in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/widevine_cdm_component_installer.cc ('k') | chrome/browser/download/download_item_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/diagnostics/diagnostics_metrics.cc

diff --git a/chrome/browser/diagnostics/diagnostics_metrics.cc b/chrome/browser/diagnostics/diagnostics_metrics.cc

index 51d4769ef198a8bf8db683f183b94801d0eaba83..eea82780a8369320a09ce00e92478d9825109a05 100644

--- a/chrome/browser/diagnostics/diagnostics_metrics.cc

+++ b/chrome/browser/diagnostics/diagnostics_metrics.cc

@@ -53,8 +53,8 @@ const TestNameInfo kTestNameInfo[] = {

// Add new entries in the same order as DiagnosticsTestId.

};

-COMPILE_ASSERT(arraysize(kTestNameInfo) == DIAGNOSTICS_TEST_ID_COUNT,

- diagnostics_test_info_mismatch);

+static_assert(arraysize(kTestNameInfo) == DIAGNOSTICS_TEST_ID_COUNT,

+ "diagnostics test info mismatch");

const TestNameInfo* FindTestInfo(DiagnosticsTestId id) {

DCHECK(id < DIAGNOSTICS_TEST_ID_COUNT);