chrome/browser/external_extension_browsertest.cc - Issue 815363002: replace COMPILE_ASSERT with static_assert in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/external_extension_browsertest.cc

Issue 815363002: replace COMPILE_ASSERT with static_assert in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api_unittest.cc ('k') | chrome/browser/history/visit_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/external_extension_browsertest.cc

diff --git a/chrome/browser/external_extension_browsertest.cc b/chrome/browser/external_extension_browsertest.cc

index 97287277ffbff7f3bbbbb77c28d8eea8ce7fb23b..a2f18de5140a8501d21e75fbaecc40b60e39b1ed 100644

--- a/chrome/browser/external_extension_browsertest.cc

+++ b/chrome/browser/external_extension_browsertest.cc

@@ -106,8 +106,8 @@ IN_PROC_BROWSER_TEST_F(SearchProviderTest,

const char* expected_results[] = { "2",

"1",

"0" };

- COMPILE_ASSERT(arraysize(test_hosts) == arraysize(expected_results),

- there_should_be_a_result_for_each_host);

+ static_assert(arraysize(test_hosts) == arraysize(expected_results),

+ "each host should have a test result");

IsSearchProviderTestData test_data[2 * arraysize(test_hosts)];

// Start results for the normal mode.

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api_unittest.cc ('k') | chrome/browser/history/visit_tracker.cc » ('j') | no next file with comments »