Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3977)

Unified Diff: chrome/browser/mac/relauncher.cc

Issue 815363002: replace COMPILE_ASSERT with static_assert in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/internal_auth.cc ('k') | chrome/browser/predictors/autocomplete_action_predictor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/mac/relauncher.cc
diff --git a/chrome/browser/mac/relauncher.cc b/chrome/browser/mac/relauncher.cc
index 0a00609fa2102c46d4b4afab83c0a0d8582709c9..48b94a9189b35ca4bbe33a1d49d38f28106ffab0 100644
--- a/chrome/browser/mac/relauncher.cc
+++ b/chrome/browser/mac/relauncher.cc
@@ -139,10 +139,10 @@ bool RelaunchAppWithHelper(const std::string& helper,
// Make sure kRelauncherSyncFD is a safe value. base::LaunchProcess will
// preserve these three FDs in forked processes, so kRelauncherSyncFD should
// not conflict with them.
- COMPILE_ASSERT(kRelauncherSyncFD != STDIN_FILENO &&
- kRelauncherSyncFD != STDOUT_FILENO &&
- kRelauncherSyncFD != STDERR_FILENO,
- kRelauncherSyncFD_must_not_conflict_with_stdio_fds);
+ static_assert(kRelauncherSyncFD != STDIN_FILENO &&
+ kRelauncherSyncFD != STDOUT_FILENO &&
+ kRelauncherSyncFD != STDERR_FILENO,
+ "kRelauncherSyncFD must not conflict with stdio fds");
base::FileHandleMappingVector fd_map;
fd_map.push_back(std::make_pair(pipe_write_fd.get(), kRelauncherSyncFD));
« no previous file with comments | « chrome/browser/internal_auth.cc ('k') | chrome/browser/predictors/autocomplete_action_predictor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698