chrome/browser/chrome_browser_main_mac.mm - Issue 815363002: replace COMPILE_ASSERT with static_assert in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_browser_main_mac.mm

Issue 815363002: replace COMPILE_ASSERT with static_assert in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_remover.cc ('k') | chrome/browser/chromeos/drive/resource_metadata_storage.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_browser_main_mac.mm

diff --git a/chrome/browser/chrome_browser_main_mac.mm b/chrome/browser/chrome_browser_main_mac.mm

index 2dc68c85646d84bccf8cb91d1eeb6ba0025563fe..11aa996607dea921ce2b2175ea17cf4c39f48403 100644

--- a/chrome/browser/chrome_browser_main_mac.mm

+++ b/chrome/browser/chrome_browser_main_mac.mm

@@ -141,8 +141,8 @@ void RecordCatSixtyFour() {

// some headroom and then leave it alone. See UMA_HISTOGRAM_ENUMERATION in

// base/metrics/histogram.h.

const int kMaxCatsAndSixtyFours = 32;

- COMPILE_ASSERT(kMaxCatsAndSixtyFours >= CAT_SIXTY_FOUR_MAX,

- CatSixtyFour_enum_grew_too_large);

+ static_assert(kMaxCatsAndSixtyFours >= CAT_SIXTY_FOUR_MAX,

+ "kMaxCatsAndSixtyFours is too large");

UMA_HISTOGRAM_ENUMERATION("OSX.CatSixtyFour",

cat_sixty_four,