chrome/browser/ui/tabs/tab_utils.cc - Issue 815363002: replace COMPILE_ASSERT with static_assert in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tabs/tab_utils.cc

Issue 815363002: replace COMPILE_ASSERT with static_assert in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/exclusive_access/fullscreen_controller_state_test.cc ('k') | chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tabs/tab_utils.cc

diff --git a/chrome/browser/ui/tabs/tab_utils.cc b/chrome/browser/ui/tabs/tab_utils.cc

index a61996701309b28c8d94d985247a30ef396d64ae..1f17621f9057367f076a8a60bfc4a6d613ac76b8 100644

--- a/chrome/browser/ui/tabs/tab_utils.cc

+++ b/chrome/browser/ui/tabs/tab_utils.cc

@@ -62,8 +62,8 @@ double TabRecordingIndicatorAnimation::GetCurrentValue() const {

scoped_ptr<TabRecordingIndicatorAnimation>

TabRecordingIndicatorAnimation::Create() {

MultiAnimation::Parts parts;

- COMPILE_ASSERT(kCaptureIndicatorThrobCycles % 2 != 0,

- must_be_odd_so_animation_finishes_in_showing_state);

+ static_assert(kCaptureIndicatorThrobCycles % 2 != 0,

+ "odd number of cycles required so animation finishes in showing state");

for (int i = 0; i < kCaptureIndicatorThrobCycles; ++i) {

parts.push_back(MultiAnimation::Part(

i % 2 ? kIndicatorFadeOutDurationMs : kIndicatorFadeInDurationMs,