Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: chrome/browser/chrome_browser_main_mac.mm

Issue 815363002: replace COMPILE_ASSERT with static_assert in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chrome_browser_main_mac.h" 5 #include "chrome/browser/chrome_browser_main_mac.h"
6 6
7 #import <Cocoa/Cocoa.h> 7 #import <Cocoa/Cocoa.h>
8 #include <sys/sysctl.h> 8 #include <sys/sysctl.h>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 SABER_TOOTHED_CAT_DUNNO; 134 SABER_TOOTHED_CAT_DUNNO;
135 } 135 }
136 136
137 void RecordCatSixtyFour() { 137 void RecordCatSixtyFour() {
138 CatSixtyFour cat_sixty_four = CatSixtyFourValue(); 138 CatSixtyFour cat_sixty_four = CatSixtyFourValue();
139 139
140 // Set this higher than the highest value in the CatSixtyFour enum to provide 140 // Set this higher than the highest value in the CatSixtyFour enum to provide
141 // some headroom and then leave it alone. See UMA_HISTOGRAM_ENUMERATION in 141 // some headroom and then leave it alone. See UMA_HISTOGRAM_ENUMERATION in
142 // base/metrics/histogram.h. 142 // base/metrics/histogram.h.
143 const int kMaxCatsAndSixtyFours = 32; 143 const int kMaxCatsAndSixtyFours = 32;
144 COMPILE_ASSERT(kMaxCatsAndSixtyFours >= CAT_SIXTY_FOUR_MAX, 144 static_assert(kMaxCatsAndSixtyFours >= CAT_SIXTY_FOUR_MAX,
145 CatSixtyFour_enum_grew_too_large); 145 "kMaxCatsAndSixtyFours is too large");
146 146
147 UMA_HISTOGRAM_ENUMERATION("OSX.CatSixtyFour", 147 UMA_HISTOGRAM_ENUMERATION("OSX.CatSixtyFour",
148 cat_sixty_four, 148 cat_sixty_four,
149 kMaxCatsAndSixtyFours); 149 kMaxCatsAndSixtyFours);
150 } 150 }
151 151
152 } // namespace 152 } // namespace
153 153
154 // ChromeBrowserMainPartsMac --------------------------------------------------- 154 // ChromeBrowserMainPartsMac ---------------------------------------------------
155 155
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 MacStartupProfiler::POST_PROFILE_INIT); 284 MacStartupProfiler::POST_PROFILE_INIT);
285 ChromeBrowserMainPartsPosix::PostProfileInit(); 285 ChromeBrowserMainPartsPosix::PostProfileInit();
286 g_browser_process->metrics_service()->RecordBreakpadRegistration( 286 g_browser_process->metrics_service()->RecordBreakpadRegistration(
287 breakpad::IsCrashReporterEnabled()); 287 breakpad::IsCrashReporterEnabled());
288 } 288 }
289 289
290 void ChromeBrowserMainPartsMac::DidEndMainMessageLoop() { 290 void ChromeBrowserMainPartsMac::DidEndMainMessageLoop() {
291 AppController* appController = [NSApp delegate]; 291 AppController* appController = [NSApp delegate];
292 [appController didEndMainMessageLoop]; 292 [appController didEndMainMessageLoop];
293 } 293 }
OLDNEW
« no previous file with comments | « chrome/browser/browsing_data/browsing_data_remover.cc ('k') | chrome/browser/chromeos/drive/resource_metadata_storage.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698