chrome/browser/profile_resetter/profile_resetter_unittest.cc - Issue 815363002: replace COMPILE_ASSERT with static_assert in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profile_resetter/profile_resetter_unittest.cc

Issue 815363002: replace COMPILE_ASSERT with static_assert in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profile_resetter/profile_resetter.h ('k') | chrome/browser/profile_resetter/resettable_settings_snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profile_resetter/profile_resetter_unittest.cc

diff --git a/chrome/browser/profile_resetter/profile_resetter_unittest.cc b/chrome/browser/profile_resetter/profile_resetter_unittest.cc

index b34d6bed85d9a529005da489a61b7ba0d7d7854f..e60f96b2aa3f46e7dd3adfd0352ef37f08dcd9bc 100644

--- a/chrome/browser/profile_resetter/profile_resetter_unittest.cc

+++ b/chrome/browser/profile_resetter/profile_resetter_unittest.cc

@@ -967,8 +967,8 @@ TEST_F(ProfileResetterTest, FeedbackSerializationTest) {

// Let it enumerate shortcuts on the FILE thread.

base::MessageLoop::current()->RunUntilIdle();

- COMPILE_ASSERT(ResettableSettingsSnapshot::ALL_FIELDS == 31,

- expand_this_test);

+ static_assert(ResettableSettingsSnapshot::ALL_FIELDS == 31,

+ "this test needs to be expanded");

for (int field_mask = 0; field_mask <= ResettableSettingsSnapshot::ALL_FIELDS;

++field_mask) {

std::string report = SerializeSettingsReport(nonorganic_snap, field_mask);