Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1648)

Side by Side Diff: chrome/browser/ui/website_settings/website_settings_ui.cc

Issue 815363002: replace COMPILE_ASSERT with static_assert in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/website_settings/website_settings_ui.h" 5 #include "chrome/browser/ui/website_settings/website_settings_ui.h"
6 6
7 #include "chrome/grit/chromium_strings.h" 7 #include "chrome/grit/chromium_strings.h"
8 #include "chrome/grit/generated_resources.h" 8 #include "chrome/grit/generated_resources.h"
9 #include "grit/theme_resources.h" 9 #include "grit/theme_resources.h"
10 #include "ui/base/l10n/l10n_util.h" 10 #include "ui/base/l10n/l10n_util.h"
11 #include "ui/base/resource/resource_bundle.h" 11 #include "ui/base/resource/resource_bundle.h"
12 #include "ui/gfx/image/image.h" 12 #include "ui/gfx/image/image.h"
13 13
14 namespace { 14 namespace {
15 15
16 const int kInvalidResourceID = -1; 16 const int kInvalidResourceID = -1;
17 17
18 // The resource id's for the strings that are displayed on the permissions 18 // The resource id's for the strings that are displayed on the permissions
19 // button if the permission setting is managed by policy. 19 // button if the permission setting is managed by policy.
20 const int kPermissionButtonTextIDPolicyManaged[] = { 20 const int kPermissionButtonTextIDPolicyManaged[] = {
21 kInvalidResourceID, 21 kInvalidResourceID,
22 IDS_WEBSITE_SETTINGS_BUTTON_TEXT_ALLOWED_BY_POLICY, 22 IDS_WEBSITE_SETTINGS_BUTTON_TEXT_ALLOWED_BY_POLICY,
23 IDS_WEBSITE_SETTINGS_BUTTON_TEXT_BLOCKED_BY_POLICY, 23 IDS_WEBSITE_SETTINGS_BUTTON_TEXT_BLOCKED_BY_POLICY,
24 kInvalidResourceID, 24 kInvalidResourceID,
25 kInvalidResourceID, 25 kInvalidResourceID,
26 kInvalidResourceID}; 26 kInvalidResourceID};
27 COMPILE_ASSERT(arraysize(kPermissionButtonTextIDPolicyManaged) == 27 static_assert(arraysize(kPermissionButtonTextIDPolicyManaged) ==
28 CONTENT_SETTING_NUM_SETTINGS, 28 CONTENT_SETTING_NUM_SETTINGS,
29 button_text_id_array_size_incorrect); 29 "kPermissionButtonTextIDPolicyManaged array size is incorrect");
30 30
31 // The resource id's for the strings that are displayed on the permissions 31 // The resource id's for the strings that are displayed on the permissions
32 // button if the permission setting is managed by an extension. 32 // button if the permission setting is managed by an extension.
33 const int kPermissionButtonTextIDExtensionManaged[] = { 33 const int kPermissionButtonTextIDExtensionManaged[] = {
34 kInvalidResourceID, 34 kInvalidResourceID,
35 IDS_WEBSITE_SETTINGS_BUTTON_TEXT_ALLOWED_BY_EXTENSION, 35 IDS_WEBSITE_SETTINGS_BUTTON_TEXT_ALLOWED_BY_EXTENSION,
36 IDS_WEBSITE_SETTINGS_BUTTON_TEXT_BLOCKED_BY_EXTENSION, 36 IDS_WEBSITE_SETTINGS_BUTTON_TEXT_BLOCKED_BY_EXTENSION,
37 kInvalidResourceID, 37 kInvalidResourceID,
38 kInvalidResourceID, 38 kInvalidResourceID,
39 kInvalidResourceID}; 39 kInvalidResourceID};
40 COMPILE_ASSERT(arraysize(kPermissionButtonTextIDExtensionManaged) == 40 static_assert(arraysize(kPermissionButtonTextIDExtensionManaged) ==
41 CONTENT_SETTING_NUM_SETTINGS, 41 CONTENT_SETTING_NUM_SETTINGS,
42 button_text_id_array_size_incorrect); 42 "kPermissionButtonTextIDExtensionManaged array size is "
43 "incorrect");
43 44
44 // The resource id's for the strings that are displayed on the permissions 45 // The resource id's for the strings that are displayed on the permissions
45 // button if the permission setting is managed by the user. 46 // button if the permission setting is managed by the user.
46 const int kPermissionButtonTextIDUserManaged[] = { 47 const int kPermissionButtonTextIDUserManaged[] = {
47 kInvalidResourceID, 48 kInvalidResourceID,
48 IDS_WEBSITE_SETTINGS_BUTTON_TEXT_ALLOWED_BY_USER, 49 IDS_WEBSITE_SETTINGS_BUTTON_TEXT_ALLOWED_BY_USER,
49 IDS_WEBSITE_SETTINGS_BUTTON_TEXT_BLOCKED_BY_USER, 50 IDS_WEBSITE_SETTINGS_BUTTON_TEXT_BLOCKED_BY_USER,
50 kInvalidResourceID, 51 kInvalidResourceID,
51 kInvalidResourceID, 52 kInvalidResourceID,
52 kInvalidResourceID}; 53 kInvalidResourceID};
53 COMPILE_ASSERT(arraysize(kPermissionButtonTextIDUserManaged) == 54 static_assert(arraysize(kPermissionButtonTextIDUserManaged) ==
54 CONTENT_SETTING_NUM_SETTINGS, 55 CONTENT_SETTING_NUM_SETTINGS,
55 button_text_id_array_size_incorrect); 56 "kPermissionButtonTextIDUserManaged array size is incorrect");
56 57
57 // The resource id's for the strings that are displayed on the permissions 58 // The resource id's for the strings that are displayed on the permissions
58 // button if the permission setting is the global default setting. 59 // button if the permission setting is the global default setting.
59 const int kPermissionButtonTextIDDefaultSetting[] = { 60 const int kPermissionButtonTextIDDefaultSetting[] = {
60 kInvalidResourceID, 61 kInvalidResourceID,
61 IDS_WEBSITE_SETTINGS_BUTTON_TEXT_ALLOWED_BY_DEFAULT, 62 IDS_WEBSITE_SETTINGS_BUTTON_TEXT_ALLOWED_BY_DEFAULT,
62 IDS_WEBSITE_SETTINGS_BUTTON_TEXT_BLOCKED_BY_DEFAULT, 63 IDS_WEBSITE_SETTINGS_BUTTON_TEXT_BLOCKED_BY_DEFAULT,
63 IDS_WEBSITE_SETTINGS_BUTTON_TEXT_ASK_BY_DEFAULT, 64 IDS_WEBSITE_SETTINGS_BUTTON_TEXT_ASK_BY_DEFAULT,
64 kInvalidResourceID, 65 kInvalidResourceID,
65 IDS_WEBSITE_SETTINGS_BUTTON_TEXT_DETECT_IMPORTANT_CONTENT_BY_DEFAULT}; 66 IDS_WEBSITE_SETTINGS_BUTTON_TEXT_DETECT_IMPORTANT_CONTENT_BY_DEFAULT};
66 COMPILE_ASSERT(arraysize(kPermissionButtonTextIDDefaultSetting) == 67 static_assert(arraysize(kPermissionButtonTextIDDefaultSetting) ==
67 CONTENT_SETTING_NUM_SETTINGS, 68 CONTENT_SETTING_NUM_SETTINGS,
68 button_text_id_array_size_incorrect); 69 "kPermissionButtonTextIDDefaultSetting array size is incorrect");
69 70
70 } // namespace 71 } // namespace
71 72
72 WebsiteSettingsUI::CookieInfo::CookieInfo() 73 WebsiteSettingsUI::CookieInfo::CookieInfo()
73 : allowed(-1), blocked(-1) { 74 : allowed(-1), blocked(-1) {
74 } 75 }
75 76
76 WebsiteSettingsUI::PermissionInfo::PermissionInfo() 77 WebsiteSettingsUI::PermissionInfo::PermissionInfo()
77 : type(CONTENT_SETTINGS_TYPE_DEFAULT), 78 : type(CONTENT_SETTINGS_TYPE_DEFAULT),
78 setting(CONTENT_SETTING_DEFAULT), 79 setting(CONTENT_SETTING_DEFAULT),
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 // the first time. 334 // the first time.
334 return IDR_PAGEINFO_INFO; 335 return IDR_PAGEINFO_INFO;
335 } 336 }
336 337
337 // static 338 // static
338 const gfx::Image& WebsiteSettingsUI::GetFirstVisitIcon( 339 const gfx::Image& WebsiteSettingsUI::GetFirstVisitIcon(
339 const base::string16& first_visit) { 340 const base::string16& first_visit) {
340 ResourceBundle& rb = ResourceBundle::GetSharedInstance(); 341 ResourceBundle& rb = ResourceBundle::GetSharedInstance();
341 return rb.GetNativeImageNamed(GetFirstVisitIconID(first_visit)); 342 return rb.GetNativeImageNamed(GetFirstVisitIconID(first_visit));
342 } 343 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698