chrome/browser/signin/signin_error_notifier_ash_unittest.cc - Issue 815363002: replace COMPILE_ASSERT with static_assert in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/signin_error_notifier_ash_unittest.cc

Issue 815363002: replace COMPILE_ASSERT with static_assert in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc ('k') | chrome/browser/signin/signin_global_error_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/signin_error_notifier_ash_unittest.cc

diff --git a/chrome/browser/signin/signin_error_notifier_ash_unittest.cc b/chrome/browser/signin/signin_error_notifier_ash_unittest.cc

index 0f5b4f2cd6f256bfe79194709173f1f9a4e2c9ed..e49b489ec6f1a5a47605d58112ce3deb202a3f8f 100644

--- a/chrome/browser/signin/signin_error_notifier_ash_unittest.cc

+++ b/chrome/browser/signin/signin_error_notifier_ash_unittest.cc

@@ -236,8 +236,8 @@ TEST_F(SigninErrorNotifierTest, AuthStatusEnumerateAllErrors) {

{ GoogleServiceAuthError::SERVICE_ERROR, true },

{ GoogleServiceAuthError::WEB_LOGIN_REQUIRED, true },

};

- COMPILE_ASSERT(arraysize(table) == GoogleServiceAuthError::NUM_STATES,

- kTable_size_does_not_match_number_of_auth_error_types);

+ static_assert(arraysize(table) == GoogleServiceAuthError::NUM_STATES,

+ "table size should match number of auth error types");

for (size_t i = 0; i < arraysize(table); ++i) {

FakeAuthStatusProvider provider(error_controller_);