Do not save finder options in PossibleApp/PossibleBrowser.

Do not save finder options in PossibleApp/PossibleBrowser.

Without this, the browser may get created with old finder_options because FindBrowser has a caching decorator.

This should fix flakiness of telemetry/page/page_runner_unittest/PageRunnerTests/testUserAgent.

http://build.chromium.org/f/chromium/flakiness/
[test type: telemetry_unittests]

BUG=428967
Committed: https://crrev.com/94a58f5df2d08032c866dbdd5e35d62cb7f5250b
Cr-Commit-Position: refs/heads/master@{#302504}

[slamm, 2014-10-30 21:02:15]

slamm@chromium.org changed reviewers:
+ nednguyen@google.com

[nednguyen, 2014-10-30 21:14:42]

On 2014/10/30 21:02:15, slamm wrote:

LGTM

[nednguyen, 2014-10-30 21:14:44]

On 2014/10/30 21:02:15, slamm wrote:

LGTM

[nednguyen, 2014-10-30 21:16:52]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-10-30 21:18:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/688903002/1

[commit-bot: I haz the power, 2014-10-30 21:27:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-30 21:27:43]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[slamm, 2014-10-30 21:31:43]

slamm@chromium.org changed reviewers:
+ achuith@chromium.org

[slamm, 2014-10-30 21:31:44]

A chromeos test needs a chromeos owner.

[slamm, 2014-10-30 21:47:23]

Rebase

[slamm, 2014-10-30 21:54:19]

Update PossibleBrowser.__init__ and Create callers.

[achuithb, 2014-10-31 08:38:43]

On 2014/10/30 21:54:19, slamm wrote:
> Update PossibleBrowser.__init__ and Create callers.

owner lgtm

[achuithb, 2014-10-31 08:43:49]

Actually, I'm sorry, but not lgtm.

This will break chromeos autotests since the public signature of PossibleBrowser
has changed.

I'll send you the relevant information tomorrow, and we can figure out how to
land this.

[chromium-reviews, 2014-10-31 15:40:31]

Okay. I will be in 43 today for a Telemetry Hackathon — Berbera in the
morning and Aksum in the afternoon.
Is there a time that would be good for you today?

On Fri, Oct 31, 2014 at 1:43 AM, <achuith@chromium.org> wrote:

> Actually, I'm sorry, but not lgtm.
>
> This will break chromeos autotests since the public signature of
> PossibleBrowser
> has changed.
>
> I'll send you the relevant information tomorrow, and we can figure out how
> to
> land this.
>
> https://codereview.chromium.org/688903002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[achuithb, 2014-10-31 20:36:07]

On 2014/10/31 15:40:31, chromium-reviews wrote:
> Okay. I will be in 43 today for a Telemetry Hackathon — Berbera in the
> morning and Aksum in the afternoon.
> Is there a time that would be good for you today?

This is the problem:
https://cs.corp.google.com/#chromeos_public/src/third_party/autotest/files/cl...

[achuithb, 2014-10-31 20:47:42]

On 2014/10/31 20:36:07, achuithb wrote:
> On 2014/10/31 15:40:31, chromium-reviews wrote:
> > Okay. I will be in 43 today for a Telemetry Hackathon — Berbera in the
> > morning and Aksum in the afternoon.
> > Is there a time that would be good for you today?
> 
> This is the problem:
>
https://cs.corp.google.com/#chromeos_public/src/third_party/autotest/files/cl...

I think I have a fix for this. Give me a few.

[achuithb, 2014-10-31 21:09:20]

https://chromium-review.googlesource.com/#/c/226815/

[achuithb, 2014-11-03 19:41:22]

On 2014/10/31 21:09:20, achuithb wrote:
> https://chromium-review.googlesource.com/#/c/226815/

Change should land in a few hours. lgtm.

[slamm, 2014-11-03 21:50:09]

The CQ bit was checked by slamm@chromium.org

[commit-bot: I haz the power, 2014-11-03 21:52:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/688903002/40001

[commit-bot: I haz the power, 2014-11-03 22:40:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-03 22:41:29]

Patchset 3 (id:??) landed as
https://crrev.com/94a58f5df2d08032c866dbdd5e35d62cb7f5250b
Cr-Commit-Position: refs/heads/master@{#302504}

[Sébastien Marchand, 2014-11-04 20:58:40]

sebmarchand@chromium.org changed reviewers:
+ sebmarchand@chromium.org

[Sébastien Marchand, 2014-11-04 20:58:41]

One comment as this is breaking the Windows PGO builder
(http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20PGO%20Buil...)

https://codereview.chromium.org/688903002/diff/40001/tools/telemetry/telemetr...
File
tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py
(right):

https://codereview.chromium.org/688903002/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py:31:
super(PossibleWebDriverBrowser, self).__init__(browser_type, target_os,
You also need to remove finder_options from here, as you removed this argument
from possible_browser.py

[slamm, 2014-11-05 00:42:30]

On 2014/11/04 20:58:41, Sébastien Marchand wrote:
> One comment as this is breaking the Windows PGO builder
>
(http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20PGO%20Buil...)
> 
>
https://codereview.chromium.org/688903002/diff/40001/tools/telemetry/telemetr...
> File
>
tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py
> (right):
> 
>
https://codereview.chromium.org/688903002/diff/40001/tools/telemetry/telemetr...
>
tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py:31:
> super(PossibleWebDriverBrowser, self).__init__(browser_type, target_os,
> You also need to remove finder_options from here, as you removed this argument
> from possible_browser.py

A created a new CL with a fix: https://codereview.chromium.org/705693002