Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1436)

Unified Diff: tools/telemetry/telemetry/core/extension_unittest.py

Issue 688903002: Do not save finder options in PossibleApp/PossibleBrowser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update PossibleBrowser.__init__ and Create callers. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/extension_unittest.py
diff --git a/tools/telemetry/telemetry/core/extension_unittest.py b/tools/telemetry/telemetry/core/extension_unittest.py
index 77e44e382af9b2ddf184557f08dac8963d1b94cf..e67f18406b2fd6fb7f54022f834c63a10ec8359e 100644
--- a/tools/telemetry/telemetry/core/extension_unittest.py
+++ b/tools/telemetry/telemetry/core/extension_unittest.py
@@ -31,7 +31,7 @@ class ExtensionTest(unittest.TestCase):
if not browser_to_create:
# May not find a browser that supports extensions.
return False
- self._browser = browser_to_create.Create()
+ self._browser = browser_to_create.Create(options)
self._extension = self._browser.extensions[load_extension]
self._extension_id = load_extension.extension_id
self.assertTrue(self._extension)
@@ -96,7 +96,7 @@ class NonExistentExtensionTest(unittest.TestCase):
load_extension = extension_to_load.ExtensionToLoad(
extension_path, options.browser_type)
browser_to_create = browser_finder.FindBrowser(options)
- with browser_to_create.Create() as b:
+ with browser_to_create.Create(options) as b:
if b.supports_extensions:
self.assertRaises(KeyError, lambda: b.extensions[load_extension])
@@ -122,7 +122,7 @@ class MultipleExtensionTest(unittest.TestCase):
self._browser = None
# May not find a browser that supports extensions.
if browser_to_create:
- self._browser = browser_to_create.Create()
+ self._browser = browser_to_create.Create(options)
def tearDown(self):
if self._browser:
@@ -165,7 +165,7 @@ class ComponentExtensionTest(unittest.TestCase):
'skipping test.')
return
- with browser_to_create.Create() as b:
+ with browser_to_create.Create(options) as b:
extension = b.extensions[load_extension]
self.assertTrue(
extension.EvaluateJavaScript('chrome.runtime != null'))

Powered by Google App Engine
This is Rietveld 408576698