Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py

Issue 688903002: Do not save finder options in PossibleApp/PossibleBrowser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update PossibleBrowser.__init__ and Create callers. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py b/tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py
index b947df77f436055b23afec20aa7180bc9be4d880..314f7d8cdf6473b5c3fff5cab18b640b12646a8d 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py
@@ -27,16 +27,15 @@ IOS_WEBKIT_DEBUG_PROXY = 'ios_webkit_debug_proxy'
class PossibleIOSBrowser(possible_browser.PossibleBrowser):
"""A running iOS browser instance."""
- def __init__(self, browser_type, finder_options):
- super(PossibleIOSBrowser, self).__init__(browser_type, 'ios',
- finder_options, True)
+ def __init__(self, browser_type, _):
+ super(PossibleIOSBrowser, self).__init__(browser_type, 'ios', True)
# TODO(baxley): Implement the following methods for iOS.
- def Create(self):
- backend = ios_browser_backend.IosBrowserBackend(
- self.finder_options.browser_options)
+ def Create(self, finder_options):
+ browser_backend = ios_browser_backend.IosBrowserBackend(
+ finder_options.browser_options)
return browser.Browser(
- backend, self._platform_backend, self._credentials_path)
+ browser_backend, self._platform_backend, self._credentials_path)
def SupportsOptions(self, finder_options):
#TODO(baxley): Implement me.

Powered by Google App Engine
This is Rietveld 408576698