Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: tools/telemetry/telemetry/core/possible_browser.py

Issue 688903002: Do not save finder options in PossibleApp/PossibleBrowser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update PossibleBrowser.__init__ and Create callers. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/possible_browser.py
diff --git a/tools/telemetry/telemetry/core/possible_browser.py b/tools/telemetry/telemetry/core/possible_browser.py
index 36607c021d746d7b85dfeb1f29529d17628930d6..9c9efce484bf2828e3bba100ac9d1b23cb03f6e1 100644
--- a/tools/telemetry/telemetry/core/possible_browser.py
+++ b/tools/telemetry/telemetry/core/possible_browser.py
@@ -11,11 +11,9 @@ class PossibleBrowser(possible_app.PossibleApp):
Call Create() to launch the browser and begin manipulating it..
"""
- def __init__(self, browser_type, target_os, finder_options,
- supports_tab_control):
+ def __init__(self, browser_type, target_os, supports_tab_control):
super(PossibleBrowser, self).__init__(app_type=browser_type,
- target_os=target_os,
- finder_options=finder_options)
+ target_os=target_os)
self._supports_tab_control = supports_tab_control
self._credentials_path = None
@@ -33,7 +31,7 @@ class PossibleBrowser(possible_app.PossibleApp):
def _InitPlatformIfNeeded(self):
raise NotImplementedError()
- def Create(self):
+ def Create(self, finder_options):
raise NotImplementedError()
def SupportsOptions(self, finder_options):

Powered by Google App Engine
This is Rietveld 408576698