tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py - Issue 688903002: Do not save finder options in PossibleApp/PossibleBrowser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py

Issue 688903002: Do not save finder options in PossibleApp/PossibleBrowser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update PossibleBrowser.__init__ and Create callers. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py ('k') | tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py » ('j') | tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py

diff --git a/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py b/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py

index 7549bb9b96e27223da347ff1beb8debe562e0704..a31593ce10199dfc989c745f97ab26ed654392cd 100644

--- a/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py

+++ b/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py

@@ -24,14 +24,13 @@ SUCCESS, NO_CHANGES, ERROR = range(3)

class PossibleTrybotBrowser(possible_browser.PossibleBrowser):

"""A script that sends a job to a trybot."""

- def __init__(self, browser_type, finder_options):

+ def __init__(self, browser_type, _):

target_os = browser_type.split('-')[1]

self._buildername = '%s_perf_bisect' % browser_type.replace(

'trybot-', '').replace('-', '_')

- super(PossibleTrybotBrowser, self).__init__(browser_type, target_os,

- finder_options, True)

+ super(PossibleTrybotBrowser, self).__init__(browser_type, target_os, True)

- def Create(self):

+ def Create(self, finder_options):

raise NotImplementedError()

def SupportsOptions(self, finder_options):