Fix-up webdriver_desktop_browser_finder based on recent API changes:

Fix-up webdriver_desktopo_browser_finder based on recent API changes:

    https://codereview.chromium.org/688903002 finder_options to Create
    https://codereview.chromium.org/656303003 Move replay out of browser.

BUG=428967, 404771
Committed: https://crrev.com/9b61aae02cbbdb4cd81b01ef2c7490aa92a97881
Cr-Commit-Position: refs/heads/master@{#303076}

[slamm, 2014-11-05 00:41:04]

slamm@chromium.org changed reviewers:
+ nednguyen@google.com

[Sébastien Marchand, 2014-11-05 00:45:47]

sebmarchand@chromium.org changed reviewers:
+ sebmarchand@chromium.org

[Sébastien Marchand, 2014-11-05 00:45:47]

Thanks for taking care of this !

[nednguyen, 2014-11-05 01:34:46]

LGTM if this fix the problem.

Sébastien Marchand: how does slamm verify that this patch fix for your bot
failure?

[Sébastien Marchand, 2014-11-05 13:33:30]

If you have access to a Windows machine then just run the following command:

"cmd": [
      "python",
      "-u",
      "$(CHROME_SRC)\\src\\tools\\perf\\run_benchmark",
      "--profiler=win_pgo_profiler",
      "--use-live-sites",
      "peacekeeper.html5"
    ],

(I don't think that the --profiler is necessary, and it might complain that you
don't have some things in your path).

Otherwise I can test your CL on my Windows machine.

[Sébastien Marchand, 2014-11-05 17:33:32]

I got the following stack trace if I try this CL locally:
Traceback (most recent call last):
  <module> at tools\perf\run_benchmark:18
    sys.exit(benchmark_runner.main())
  main at tools\telemetry\telemetry\benchmark_runner.py:336
    return command().Run(options)
  Run at tools\telemetry\telemetry\benchmark_runner.py:169
    return min(255, self._benchmark().Run(args))
  Run at tools\telemetry\telemetry\benchmark.py:106
    page_runner.Run(pt, us, expectations, finder_options, results)
  Run at tools\telemetry\telemetry\page\page_runner.py:404
    test, page_set, expectations, page, results, state)
  _RunPageAndRetryRunIfNeeded at
tools\telemetry\telemetry\page\page_runner.py:306
    state.WillRunPage(page)
  WillRunPage at tools\telemetry\telemetry\page\page_runner.py:66
    self._StartProfiling(self._current_page)
  _StartProfiling at tools\telemetry\telemetry\page\page_runner.py:219
    page.file_safe_name)
AttributeError: 'NoneType' object has no attribute 'file_safe_name'

[nednguyen, 2014-11-05 17:38:25]

On 2014/11/05 17:33:32, Sébastien Marchand wrote:
> I got the following stack trace if I try this CL locally:
> Traceback (most recent call last):
>   <module> at tools\perf\run_benchmark:18
>     sys.exit(benchmark_runner.main())
>   main at tools\telemetry\telemetry\benchmark_runner.py:336
>     return command().Run(options)
>   Run at tools\telemetry\telemetry\benchmark_runner.py:169
>     return min(255, self._benchmark().Run(args))
>   Run at tools\telemetry\telemetry\benchmark.py:106
>     page_runner.Run(pt, us, expectations, finder_options, results)
>   Run at tools\telemetry\telemetry\page\page_runner.py:404
>     test, page_set, expectations, page, results, state)
>   _RunPageAndRetryRunIfNeeded at
> tools\telemetry\telemetry\page\page_runner.py:306
>     state.WillRunPage(page)
>   WillRunPage at tools\telemetry\telemetry\page\page_runner.py:66
>     self._StartProfiling(self._current_page)
>   _StartProfiling at tools\telemetry\telemetry\page\page_runner.py:219
>     page.file_safe_name)
> AttributeError: 'NoneType' object has no attribute 'file_safe_name'

Sorry, it's my fault. I make a patch fix in
https://codereview.chromium.org/702863003/

[slamm, 2014-11-06 00:03:15]

Rebase

[slamm, 2014-11-06 00:03:39]

Patchset #2 (id:20001) has been deleted

[Sébastien Marchand, 2014-11-06 17:52:04]

I confirm that this fix my issues. LGTM. Thanks.

[nednguyen, 2014-11-06 17:52:21]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-11-06 17:53:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/705693002/1

[chromium-reviews, 2014-11-06 17:58:01]

Great. Thank you for retesting it.

On Thu, Nov 6, 2014 at 9:53 AM, <commit-bot@chromium.org> wrote:

> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/705693002/1
>
>
> https://codereview.chromium.org/705693002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-11-06 19:51:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-06 19:52:32]

Patchset 1 (id:??) landed as
https://crrev.com/9b61aae02cbbdb4cd81b01ef2c7490aa92a97881
Cr-Commit-Position: refs/heads/master@{#303076}