tools/telemetry/telemetry/core/browser.py - Issue 688903002: Do not save finder options in PossibleApp/PossibleBrowser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/browser.py

Issue 688903002: Do not save finder options in PossibleApp/PossibleBrowser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update PossibleBrowser.__init__ and Create callers. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py ('K') | « tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py ('k') | tools/telemetry/telemetry/core/browser_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/browser.py

diff --git a/tools/telemetry/telemetry/core/browser.py b/tools/telemetry/telemetry/core/browser.py

index 59177ef489f015d895462eb67faa4ee83811c974..74fb63c2b45561126d5f124180d45dd3763a3850 100644

--- a/tools/telemetry/telemetry/core/browser.py

+++ b/tools/telemetry/telemetry/core/browser.py

@@ -23,7 +23,7 @@ class Browser(app.App):

Be sure to clean up after yourself by calling Close() when you are done with

the browser. Or better yet:

browser_to_create = FindBrowser(options)

- with browser_to_create.Create() as browser:

+ with browser_to_create.Create(options) as browser:

... do all your operations on browser here

"""

def __init__(self, backend, platform_backend, credentials_path):