chrome/test/telemetry/chromeos/login_unittest.py - Issue 688903002: Do not save finder options in PossibleApp/PossibleBrowser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/telemetry/chromeos/login_unittest.py

Issue 688903002: Do not save finder options in PossibleApp/PossibleBrowser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update PossibleBrowser.__init__ and Create callers. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | tools/telemetry/examples/telemetry_perf_test.py » ('j') | tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/telemetry/chromeos/login_unittest.py

diff --git a/chrome/test/telemetry/chromeos/login_unittest.py b/chrome/test/telemetry/chromeos/login_unittest.py

index 86b8aba13af33d7534f429cc7d5eda4e95f58299..8066552f3e9e6f8f7e91d4c855ba4fca9423320f 100644

--- a/chrome/test/telemetry/chromeos/login_unittest.py

+++ b/chrome/test/telemetry/chromeos/login_unittest.py

@@ -47,7 +47,7 @@ class CrOSAutoTest(unittest.TestCase):

self.assertTrue(browser_to_create)

options.browser_options.create_browser_with_oobe = True

options.browser_options.auto_login = auto_login

- b = browser_to_create.Create()

+ b = browser_to_create.Create(options)

b.Start()

return b