tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py - Issue 688903002: Do not save finder options in PossibleApp/PossibleBrowser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py

Issue 688903002: Do not save finder options in PossibleApp/PossibleBrowser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update PossibleBrowser.__init__ and Create callers. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py ('k') | tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py » ('j') | tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py

diff --git a/tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py b/tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py

index ef292d6853bf1593851cf7e7766eb546d440c5cb..67c7ec31a5d5f812bde459af9da62be2edbf6a7a 100644

--- a/tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py

+++ b/tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py

@@ -36,7 +36,7 @@ class FormBasedCredentialsBackendUnitTestBase(unittest.TestCase):

return

options = options_for_unittests.GetCopy()

- with browser_finder.FindBrowser(options).Create() as b:

+ with browser_finder.FindBrowser(options).Create(options) as b:

b.credentials.credentials_path = credentials_path

if not b.credentials.CanLogin(self._credentials_type):

return