Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: tools/telemetry/telemetry/core/possible_app.py

Issue 688903002: Do not save finder options in PossibleApp/PossibleBrowser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update PossibleBrowser.__init__ and Create callers. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/possible_app.py
diff --git a/tools/telemetry/telemetry/core/possible_app.py b/tools/telemetry/telemetry/core/possible_app.py
index 63bdb8f0ec524c84eef9e68ab155c16d8ad63e28..9e065dc21d0aa6f170337c6b728d519e6fdadb63 100644
--- a/tools/telemetry/telemetry/core/possible_app.py
+++ b/tools/telemetry/telemetry/core/possible_app.py
@@ -9,10 +9,9 @@ class PossibleApp(object):
Call Create() to launch the app and begin manipulating it.
"""
- def __init__(self, app_type, target_os, finder_options):
+ def __init__(self, app_type, target_os):
self._app_type = app_type
self._target_os = target_os
- self._finder_options = finder_options
self._platform = None
self._platform_backend = None
@@ -29,10 +28,6 @@ class PossibleApp(object):
return self._target_os
@property
- def finder_options(self):
- return self._finder_options
-
- @property
def platform(self):
self._InitPlatformIfNeeded()
return self._platform
@@ -40,7 +35,7 @@ class PossibleApp(object):
def _InitPlatformIfNeeded(self):
raise NotImplementedError()
- def Create(self):
+ def Create(self, finder_options):
raise NotImplementedError()
def SupportsOptions(self, finder_options):

Powered by Google App Engine
This is Rietveld 408576698