Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 684613002: Standardize usage of virtual/override/final specifiers. (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
Reviewers:
James Hawkins
CC:
asanka, asvitkine+watch_chromium.org, benjhayden+dwatch_chromium.org, benquan, browser-components-watch_chromium.org, cbentzel+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, davidben+watch_chromium.org, David Black, Dane Wallinga, dhollowa+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, dyu1, eroman, estade+watch_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, gavinp+prer_chromium.org, groby+spellwatch_chromium.org, Ilya Sherman, jam, Jered, jfweitz+watch_chromium.org, jkarlin+watch_chromium.org, kmadhusu+watch_chromium.org, marja+watch_chromium.org, markusheintz_, mcasas+watch_chromium.org, melevin+watch_chromium.org, mmenke, Michael van Ouwerkerk, native-client-reviews_googlegroups.com, pam+watch_chromium.org, peter+watch_chromium.org, posciak+watch_chromium.org, rginda+watch_chromium.org, rlp+watch_chromium.org, rouslan+autofillwatch_chromium.org, rouslan+spellwatch_chromium.org, samarth+watch_chromium.org, shishir+watch_chromium.org, skanuj+watch_chromium.org, stuartmorgan+watch_chromium.org, James Su, tburkard+watch_chromium.org, tfarina, wjia+watch_chromium.org, yoshiki+watch_chromium.org, zea+watch_chromium.org, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final specifiers. The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=jhawkins@chromium.org Committed: https://crrev.com/e1bc798bf7bf270dfbaa1814bba36d0676de8d7d Cr-Commit-Position: refs/heads/master@{#301990}

Patch Set 1 #

Total comments: 11

Patch Set 2 : Fix bad indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+450 lines, -514 lines) Patch
M chrome/browser/about_flags_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/apps/custom_launcher_page_browsertest_views.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/apps/drive/drive_app_converter_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/drive/drive_app_mapping_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/apps/drive/drive_app_provider_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/ephemeral_app_browsertest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/ephemeral_app_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/speech_recognition_browsertest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/apps/web_view_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/bookmark_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/builtin_provider_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/keyword_extensions_delegate_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_backend_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_delegate_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autofill/autofill_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/form_structure_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_application_list_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_contents_service_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/background/background_mode_manager_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/bitmap_fetcher/bitmap_fetcher_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bitmap_fetcher/bitmap_fetcher_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/chrome_bookmark_client_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_channel_id_helper_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_indexed_db_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/browsing_data/cookies_tree_model_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_tab_reloader_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_extra_parts_x11.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chrome_browser_main_linux.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_security_exploit_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/test/cld_component_installer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/test/component_updater_service_unittest.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/content_settings/content_settings_default_provider_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/content_settings/permission_context_base_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/permission_queue_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/copresence/chrome_whispernet_client_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/diagnostics/diagnostics_controller_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/diagnostics/diagnostics_model_unittest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_danger_prompt_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/download/download_dir_policy_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_history_unittest.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/download/download_path_reservation_tracker_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_query_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/download/download_request_limiter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_shelf_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_status_updater_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_ui_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/drive/drive_app_registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/drive/drive_uploader_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/external_protocol/external_protocol_handler_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/favicon/favicon_handler_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/file_select_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/first_run_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/first_run/first_run_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/google/google_search_counter_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/google/google_update_settings_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox_importer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox_profile_lock_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/importer/profile_writer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/internal_auth_unittest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/invalidation/gcm_invalidation_bridge_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/invalidation/invalidator_storage_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/invalidation/ticl_profile_settings_provider_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/media/chrome_media_stream_infobar_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/chrome_webrtc_disable_encryption_flag_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/desktop_media_list_ash_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/encrypted_media_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/media_browsertest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/webrtc_browsertest_base.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/webrtc_log_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/thread_watcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/test/nacl_gdb_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_network_delegate_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/net/dns_probe_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/evicted_domain_cookie_counter_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/net/load_timing_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/net/net_error_tab_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/net_log_temp_file_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/network_stats_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/net/predictor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/pref_proxy_config_tracker_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/probe_message_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/proxy_browsertest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/net/proxy_policy_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/quota_policy_channel_id_store_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/safe_search_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_profile_util_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/notifications/extension_welcome_notification_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/message_center_notifications_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/message_center_settings_controller_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/notifications/notification_conversion_helper_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_prefs_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_invalidator_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/javascript_policy_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/policy/profile_policy_connector_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/url_blacklist_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/power/process_power_collector_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor_table_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_tables_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/predictors/resource_prefetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/chrome_pref_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/incognito_mode_prefs_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/leveldb_pref_store_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/prefs/pref_model_associator_unittest.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/prefs/prefs_syncable_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/proxy_policy_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/prefs/session_startup_pref_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/tracked/pref_hash_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/tracked/pref_service_hash_store_contents_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/tracked/segregated_pref_store_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/prefs/tracked/tracked_preferences_migration_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/prerender/prerender_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_preview_pdf_generated_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_preview_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/process_singleton_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/process_singleton_posix_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profile_resetter/profile_resetter_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/gaia_info_update_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_downloader_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache_unittest.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_list_desktop_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/referrer_policy_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_context_menu/spellchecker_submenu_observer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/screensaver_window_finder_x11.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/hotword_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/iframe_source_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/search/instant_service_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/search/instant_unittest_base.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/search/most_visited_iframe_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/search_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/default_search_pref_migration_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/search_provider_install_data_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/services/gcm/gcm_account_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/services/gcm/push_messaging_browsertest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sessions/better_session_restore_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sessions/persistent_tab_restore_service_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/sessions/session_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/shell_integration_linux_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/signin/account_reconcilor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/signin/signin_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/signin_error_notifier_ash.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/signin/signin_error_notifier_ash.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/signin/signin_error_notifier_ash_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/signin_error_notifier_factory_ash.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/signin_global_error_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/signin/signin_names_io_thread_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/signin_tracker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/speech/tts_linux.cc View 2 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/spellchecker/feedback_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/feedback_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_host_metrics_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_client_certificate_selector_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/status_icons/status_icon_menu_model_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_pref_mapping_service_unittest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_pref_store_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_refresh_token_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_registration_utility_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_resource_throttle_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_service_unittest.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_settings_service_unittest.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_shared_settings_service_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_shared_settings_update_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_sync_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_url_filter_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/theme_service_aurax11.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/themes/theme_service_aurax11.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/themes/theme_service_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/themes/theme_service_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/themes/theme_syncable_service_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/undo/bookmark_undo_service_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/web_applications/web_app_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_resource/eula_accepted_notifier_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_resource/resource_request_allowed_notifier_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/webdata/keyword_table_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (1 generated)
dcheng
6 years, 1 month ago (2014-10-27 21:26:27 UTC) #1
James Hawkins
I stopped reviewing at cloud_print_proxy_process_browsertest.cc. Please go through these CLs and remove all of the ...
6 years, 1 month ago (2014-10-28 23:04:23 UTC) #2
dcheng
On 2014/10/28 23:04:23, James Hawkins wrote: > I stopped reviewing at cloud_print_proxy_process_browsertest.cc. Please go > ...
6 years, 1 month ago (2014-10-28 23:10:41 UTC) #3
James Hawkins
On 2014/10/28 23:10:41, dcheng wrote: > On 2014/10/28 23:04:23, James Hawkins wrote: > > I ...
6 years, 1 month ago (2014-10-28 23:12:11 UTC) #4
dcheng
On 2014/10/28 23:10:41, dcheng wrote: > On 2014/10/28 23:04:23, James Hawkins wrote: > > I ...
6 years, 1 month ago (2014-10-28 23:15:30 UTC) #5
James Hawkins
On 2014/10/28 23:15:30, dcheng wrote: > On 2014/10/28 23:10:41, dcheng wrote: > > On 2014/10/28 ...
6 years, 1 month ago (2014-10-28 23:18:49 UTC) #6
dcheng
On 2014/10/28 at 23:18:49, jhawkins wrote: > Sure, maybe clang-format needs a strict mode in ...
6 years, 1 month ago (2014-10-29 20:51:54 UTC) #7
James Hawkins
On 2014/10/29 20:51:54, dcheng wrote: > On 2014/10/28 at 23:18:49, jhawkins wrote: > > Sure, ...
6 years, 1 month ago (2014-10-29 20:56:00 UTC) #8
dcheng
On 2014/10/29 at 20:56:00, jhawkins wrote: > On 2014/10/29 20:51:54, dcheng wrote: > > On ...
6 years, 1 month ago (2014-10-29 20:58:34 UTC) #9
James Hawkins
On 2014/10/29 20:58:34, dcheng wrote: > On 2014/10/29 at 20:56:00, jhawkins wrote: > > On ...
6 years, 1 month ago (2014-10-29 21:52:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684613002/20001
6 years, 1 month ago (2014-10-29 22:07:23 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-30 00:34:55 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 00:35:37 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1bc798bf7bf270dfbaa1814bba36d0676de8d7d
Cr-Commit-Position: refs/heads/master@{#301990}

Powered by Google App Engine
This is Rietveld 408576698