chrome/browser/captive_portal/captive_portal_tab_reloader_unittest.cc - Issue 684613002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/captive_portal/captive_portal_tab_reloader_unittest.cc

Issue 684613002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bad indent Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc ('k') | chrome/browser/chrome_browser_main_extra_parts_x11.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/captive_portal/captive_portal_tab_reloader_unittest.cc

diff --git a/chrome/browser/captive_portal/captive_portal_tab_reloader_unittest.cc b/chrome/browser/captive_portal/captive_portal_tab_reloader_unittest.cc

index ccbcd038f40eb45aa07fe96fa36eb91dc47c7d13..cf8643964dcdbf4967950c5697a382e85f03b10e 100644

--- a/chrome/browser/captive_portal/captive_portal_tab_reloader_unittest.cc

+++ b/chrome/browser/captive_portal/captive_portal_tab_reloader_unittest.cc

@@ -85,7 +85,7 @@ class MockInterstitialPageDelegate : public content::InterstitialPageDelegate {

class CaptivePortalTabReloaderTest : public ChromeRenderViewHostTestHarness {

public:

// testing::Test:

- virtual void SetUp() override {

+ void SetUp() override {

ChromeRenderViewHostTestHarness::SetUp();

tab_reloader_.reset(new testing::StrictMock<TestCaptivePortalTabReloader>(

web_contents()));

@@ -94,7 +94,7 @@ class CaptivePortalTabReloaderTest : public ChromeRenderViewHostTestHarness {

tab_reloader_->set_slow_ssl_load_time(base::TimeDelta());

}

- virtual void TearDown() override {

+ void TearDown() override {

EXPECT_FALSE(tab_reloader().TimerRunning());

tab_reloader_.reset(NULL);

ChromeRenderViewHostTestHarness::TearDown();