chrome/browser/signin/signin_browsertest.cc - Issue 684613002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/signin_browsertest.cc

Issue 684613002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bad indent Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc ('k') | chrome/browser/signin/signin_error_notifier_ash.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/signin_browsertest.cc

diff --git a/chrome/browser/signin/signin_browsertest.cc b/chrome/browser/signin/signin_browsertest.cc

index b7645c4d3d11ad7c8afeaaba7a31ab2fa15c6abd..a3ff1fc4cd34f726b62c0225a019145bbe2201da 100644

--- a/chrome/browser/signin/signin_browsertest.cc

+++ b/chrome/browser/signin/signin_browsertest.cc

@@ -56,7 +56,7 @@ class SigninBrowserTest : public InProcessBrowserTest {

command_line->AppendSwitch(switches::kEnableWebBasedSignin);

}

- virtual void SetUp() override {

+ void SetUp() override {

factory_.reset(new net::URLFetcherImplFactory());

fake_factory_.reset(new net::FakeURLFetcherFactory(factory_.get()));

fake_factory_->SetFakeResponse(

@@ -69,7 +69,7 @@ class SigninBrowserTest : public InProcessBrowserTest {

InProcessBrowserTest::SetUp();

}

- virtual void TearDown() override {

+ void TearDown() override {

if (fake_factory_.get()) {

fake_factory_->ClearFakeResponses();

fake_factory_.reset();