chrome/browser/printing/print_dialog_cloud_unittest.cc - Issue 684613002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_dialog_cloud_unittest.cc

Issue 684613002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bad indent Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc ('k') | chrome/browser/printing/print_preview_dialog_controller_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_dialog_cloud_unittest.cc

diff --git a/chrome/browser/printing/print_dialog_cloud_unittest.cc b/chrome/browser/printing/print_dialog_cloud_unittest.cc

index 17e468e5dc704be8050c70d692e623ec313a4629..42f44dd2fe2ae7838ac502cdd0759846c5ae9988 100644

--- a/chrome/browser/printing/print_dialog_cloud_unittest.cc

+++ b/chrome/browser/printing/print_dialog_cloud_unittest.cc

@@ -145,7 +145,7 @@ class CloudPrintDataSenderTest : public testing::Test {

io_thread_(BrowserThread::IO, &message_loop_) {}

protected:

- virtual void SetUp() {

+ void SetUp() override {

mock_helper_.reset(new MockCloudPrintDataSenderHelper);

}

@@ -222,7 +222,7 @@ class CloudPrintWebDialogDelegateTest : public testing::Test {

: ui_thread_(BrowserThread::UI, &message_loop_) {}

protected:

- virtual void SetUp() {

+ void SetUp() override {

base::string16 mock_title;

base::string16 mock_print_ticket;

std::string mock_file_type;

@@ -236,7 +236,7 @@ class CloudPrintWebDialogDelegateTest : public testing::Test {

std::string()));

}

- virtual void TearDown() {

+ void TearDown() override {

delegate_.reset();

if (mock_flow_handler_.get())

delete mock_flow_handler_.get();