chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc - Issue 684613002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

Issue 684613002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bad indent Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/copresence/chrome_whispernet_client_browsertest.cc ('k') | chrome/browser/diagnostics/diagnostics_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

diff --git a/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc b/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

index e28c034b8998d15762cfb93f736012e4d5a3ec91..ab54350c7d2f96637aa11fc8fb5a7d6b646f64c3 100644

--- a/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

+++ b/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

@@ -390,7 +390,7 @@ class ProtocolHandlerRegistryTest : public testing::Test {

// Registry owns the delegate_ it handles deletion of that object.

}

- virtual void SetUp() {

+ void SetUp() override {

profile_.reset(new TestingProfile());

CHECK(profile_->GetPrefs());

SetUpRegistry(true);

@@ -398,9 +398,7 @@ class ProtocolHandlerRegistryTest : public testing::Test {

CreateProtocolHandler("test", GURL("http://test.com/%s"));

}

- virtual void TearDown() {

- TeadDownRegistry();

- }

+ void TearDown() override { TeadDownRegistry(); }

TestMessageLoop loop_;