chrome/browser/diagnostics/diagnostics_controller_unittest.cc - Issue 684613002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/diagnostics/diagnostics_controller_unittest.cc

Issue 684613002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bad indent Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc ('k') | chrome/browser/diagnostics/diagnostics_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/diagnostics/diagnostics_controller_unittest.cc

diff --git a/chrome/browser/diagnostics/diagnostics_controller_unittest.cc b/chrome/browser/diagnostics/diagnostics_controller_unittest.cc

index 3377c9b012a4e89d8a16c3679cd5f8ee075ac8b7..617cc4e2590cabbc32076c44e149180cd95aa63c 100644

--- a/chrome/browser/diagnostics/diagnostics_controller_unittest.cc

+++ b/chrome/browser/diagnostics/diagnostics_controller_unittest.cc

@@ -26,9 +26,9 @@ class DiagnosticsControllerTest : public testing::Test {

protected:

DiagnosticsControllerTest() : cmdline_(CommandLine::NO_PROGRAM) {}

- virtual ~DiagnosticsControllerTest() {}

+ ~DiagnosticsControllerTest() override {}

- virtual void SetUp() {

+ void SetUp() override {

ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());

base::FilePath test_data;

PathService::Get(chrome::DIR_TEST_DATA, &test_data);

@@ -54,7 +54,7 @@ class DiagnosticsControllerTest : public testing::Test {

// writer_.reset(new DiagnosticsWriter(DiagnosticsWriter::MACHINE));

}

- virtual void TearDown() {

+ void TearDown() override {

DiagnosticsController::GetInstance()->ClearResults();

#if defined(OS_CHROMEOS)

PathService::Override(base::DIR_HOME, old_home_dir_);