chrome/browser/supervised_user/supervised_user_shared_settings_service_unittest.cc - Issue 684613002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/supervised_user_shared_settings_service_unittest.cc

Issue 684613002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bad indent Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/supervised_user_settings_service_unittest.cc ('k') | chrome/browser/supervised_user/supervised_user_shared_settings_update_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/supervised_user_shared_settings_service_unittest.cc

diff --git a/chrome/browser/supervised_user/supervised_user_shared_settings_service_unittest.cc b/chrome/browser/supervised_user/supervised_user_shared_settings_service_unittest.cc

index 72e3f8e776779ed96b7d8063eb351645f8c0402a..619daca538eef3d38fd6796fce6c8e5db6a904da 100644

--- a/chrome/browser/supervised_user/supervised_user_shared_settings_service_unittest.cc

+++ b/chrome/browser/supervised_user/supervised_user_shared_settings_service_unittest.cc

@@ -81,7 +81,7 @@ class SupervisedUserSharedSettingsServiceTest : public ::testing::Test {

SupervisedUserSharedSettingsServiceTest()

: settings_service_(profile_.GetPrefs()) {}

- virtual ~SupervisedUserSharedSettingsServiceTest() {}

+ ~SupervisedUserSharedSettingsServiceTest() override {}

void StartSyncing(const syncer::SyncDataList& initial_sync_data) {

sync_processor_.reset(new syncer::FakeSyncChangeProcessor);

@@ -114,13 +114,13 @@ class SupervisedUserSharedSettingsServiceTest : public ::testing::Test {

}

// testing::Test overrides:

- virtual void SetUp() override {

+ void SetUp() override {

subscription_ = settings_service_.Subscribe(

base::Bind(&SupervisedUserSharedSettingsServiceTest::OnSettingChanged,

base::Unretained(this)));

}

- virtual void TearDown() override { settings_service_.Shutdown(); }

+ void TearDown() override { settings_service_.Shutdown(); }

void OnSettingChanged(const std::string& su_id, const std::string& key) {

const Value* value = settings_service_.GetValue(su_id, key);