Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Unified Diff: chrome/browser/services/gcm/push_messaging_browsertest.cc

Issue 684613002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bad indent Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/services/gcm/push_messaging_browsertest.cc
diff --git a/chrome/browser/services/gcm/push_messaging_browsertest.cc b/chrome/browser/services/gcm/push_messaging_browsertest.cc
index c44f7bbdeec311664a61219cd1e52cf63ba827c5..21d08e2b407a204f01145d59f0338fea6899e791 100644
--- a/chrome/browser/services/gcm/push_messaging_browsertest.cc
+++ b/chrome/browser/services/gcm/push_messaging_browsertest.cc
@@ -44,7 +44,7 @@ class InfoBarResponder : public infobars::InfoBarManager::Observer {
virtual ~InfoBarResponder() { infobar_service_->RemoveObserver(this); }
// infobars::InfoBarManager::Observer
- virtual void OnInfoBarAdded(infobars::InfoBar* infobar) override {
+ void OnInfoBarAdded(infobars::InfoBar* infobar) override {
if (has_observed_)
return;
has_observed_ = true;
@@ -77,10 +77,10 @@ class InfoBarResponder : public infobars::InfoBarManager::Observer {
class PushMessagingBrowserTest : public InProcessBrowserTest {
public:
PushMessagingBrowserTest() : gcm_service_(nullptr) {}
- virtual ~PushMessagingBrowserTest() {}
+ ~PushMessagingBrowserTest() override {}
// InProcessBrowserTest:
- virtual void SetUpCommandLine(base::CommandLine* command_line) override {
+ void SetUpCommandLine(base::CommandLine* command_line) override {
command_line->AppendSwitch(
switches::kEnableExperimentalWebPlatformFeatures);
@@ -88,7 +88,7 @@ class PushMessagingBrowserTest : public InProcessBrowserTest {
}
// InProcessBrowserTest:
- virtual void SetUp() override {
+ void SetUp() override {
https_server_.reset(new net::SpawnedTestServer(
net::SpawnedTestServer::TYPE_HTTPS,
net::BaseTestServer::SSLOptions(
@@ -100,7 +100,7 @@ class PushMessagingBrowserTest : public InProcessBrowserTest {
}
// InProcessBrowserTest:
- virtual void SetUpOnMainThread() override {
+ void SetUpOnMainThread() override {
gcm_service_ = static_cast<FakeGCMProfileService*>(
GCMProfileServiceFactory::GetInstance()->SetTestingFactoryAndUse(
browser()->profile(), &FakeGCMProfileService::Build));

Powered by Google App Engine
This is Rietveld 408576698