chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc - Issue 684613002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc

Issue 684613002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bad indent Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/captive_portal/captive_portal_service_unittest.cc ('k') | chrome/browser/captive_portal/captive_portal_tab_reloader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc

diff --git a/chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc b/chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc

index 5a44cbf99f7a19014fd6f04c9d71b22ea0c40190..962ba284d9a6b7c55b219f202d7768a3ca51073f 100644

--- a/chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc

+++ b/chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc

@@ -70,15 +70,15 @@ class CaptivePortalTabHelperTest : public ChromeRenderViewHostTestHarness {

mock_reloader_(new testing::StrictMock<MockCaptivePortalTabReloader>) {

tab_helper_.SetTabReloaderForTest(mock_reloader_);

}

- virtual ~CaptivePortalTabHelperTest() {}

+ ~CaptivePortalTabHelperTest() override {}

- virtual void SetUp() override {

+ void SetUp() override {

ChromeRenderViewHostTestHarness::SetUp();

web_contents1_.reset(CreateTestWebContents());

web_contents2_.reset(CreateTestWebContents());

}

- virtual void TearDown() override {

+ void TearDown() override {

web_contents2_.reset(NULL);

web_contents1_.reset(NULL);

ChromeRenderViewHostTestHarness::TearDown();