chrome/browser/prerender/prerender_browsertest.cc - Issue 684613002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 684613002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bad indent Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/prefs/tracked/tracked_preferences_migration_unittest.cc ('k') | chrome/browser/prerender/prerender_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/prerender/prerender_browsertest.cc

diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc

index 48a9eb595014ee11e379040f9294a16ad3cbf93e..0aa25da296110cf3fecf5a1c1573bcab29654a2a 100644

--- a/chrome/browser/prerender/prerender_browsertest.cc

+++ b/chrome/browser/prerender/prerender_browsertest.cc

@@ -1048,7 +1048,7 @@ class PrerenderBrowserTest : virtual public InProcessBrowserTest {

loader_path_("files/prerender/prerender_loader.html"),

explicitly_set_browser_(NULL) {}

- virtual ~PrerenderBrowserTest() {}

+ ~PrerenderBrowserTest() override {}

content::SessionStorageNamespace* GetSessionStorageNamespace() const {

WebContents* web_contents = GetActiveWebContents();

@@ -3527,7 +3527,7 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,

class PrerenderBrowserTestWithNaCl : public PrerenderBrowserTest {

public:

PrerenderBrowserTestWithNaCl() {}

- virtual ~PrerenderBrowserTestWithNaCl() {}

+ ~PrerenderBrowserTestWithNaCl() override {}

void SetUpCommandLine(CommandLine* command_line) override {

PrerenderBrowserTest::SetUpCommandLine(command_line);

@@ -3615,9 +3615,7 @@ class PrerenderBrowserTestWithExtensions : public PrerenderBrowserTest,

autostart_test_server_ = false;

}

- virtual void SetUp() override {

- PrerenderBrowserTest::SetUp();

- }

+ void SetUp() override { PrerenderBrowserTest::SetUp(); }

void SetUpCommandLine(CommandLine* command_line) override {

PrerenderBrowserTest::SetUpCommandLine(command_line);